Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a20fc81

Browse files
committed
fix forgetting to forward encode.
1 parent be04fa0 commit a20fc81

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

impeller/aiks/aiks_unittests.cc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1913,7 +1913,6 @@ TEST_P(AiksTest,
19131913
GetBackend() == PlaygroundBackend::kOpenGLES ? 4llu : 3llu);
19141914
std::shared_ptr<RenderPass> render_pass = spy->render_passes_[0];
19151915
ASSERT_EQ(render_pass->GetCommands().size(), 0llu);
1916-
render_pass->EncodeCommands();
19171916
}
19181917

19191918
TEST_P(AiksTest, DrawRectAbsorbsClears) {
@@ -1934,7 +1933,6 @@ TEST_P(AiksTest, DrawRectAbsorbsClears) {
19341933
ASSERT_EQ(spy->render_passes_.size(), 1llu);
19351934
std::shared_ptr<RenderPass> render_pass = spy->render_passes_[0];
19361935
ASSERT_EQ(render_pass->GetCommands().size(), 0llu);
1937-
render_pass->EncodeCommands();
19381936
}
19391937

19401938
TEST_P(AiksTest, DrawRectAbsorbsClearsNegativeRRect) {
@@ -1955,7 +1953,6 @@ TEST_P(AiksTest, DrawRectAbsorbsClearsNegativeRRect) {
19551953
ASSERT_EQ(spy->render_passes_.size(), 1llu);
19561954
std::shared_ptr<RenderPass> render_pass = spy->render_passes_[0];
19571955
ASSERT_EQ(render_pass->GetCommands().size(), 2llu);
1958-
render_pass->EncodeCommands();
19591956
}
19601957

19611958
TEST_P(AiksTest, DrawRectAbsorbsClearsNegativeRotation) {
@@ -1976,7 +1973,6 @@ TEST_P(AiksTest, DrawRectAbsorbsClearsNegativeRotation) {
19761973
ASSERT_EQ(spy->render_passes_.size(), 1llu);
19771974
std::shared_ptr<RenderPass> render_pass = spy->render_passes_[0];
19781975
ASSERT_EQ(render_pass->GetCommands().size(), 1llu);
1979-
render_pass->EncodeCommands();
19801976
}
19811977

19821978
TEST_P(AiksTest, DrawRectAbsorbsClearsNegative) {
@@ -1997,7 +1993,6 @@ TEST_P(AiksTest, DrawRectAbsorbsClearsNegative) {
19971993
ASSERT_EQ(spy->render_passes_.size(), 1llu);
19981994
std::shared_ptr<RenderPass> render_pass = spy->render_passes_[0];
19991995
ASSERT_EQ(render_pass->GetCommands().size(), 2llu);
2000-
render_pass->EncodeCommands();
20011996
}
20021997

20031998
TEST_P(AiksTest, ClipRectElidesNoOpClips) {
@@ -2022,7 +2017,6 @@ TEST_P(AiksTest, ClipRectElidesNoOpClips) {
20222017
ASSERT_EQ(spy->render_passes_.size(), 1llu);
20232018
std::shared_ptr<RenderPass> render_pass = spy->render_passes_[0];
20242019
ASSERT_EQ(render_pass->GetCommands().size(), 0llu);
2025-
render_pass->EncodeCommands();
20262020
}
20272021

20282022
TEST_P(AiksTest, ClearColorOptimizationDoesNotApplyForBackdropFilters) {

impeller/entity/contents/test/recording_render_pass.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ void RecordingRenderPass::OnSetLabel(std::string label) {
7878

7979
// |RenderPass|
8080
bool RecordingRenderPass::OnEncodeCommands(const Context& context) const {
81-
return true;
81+
return delegate_->EncodeCommands();
8282
}
8383

8484
// |RenderPass|

0 commit comments

Comments
 (0)