Skip to content

Commit

Permalink
Exclude the Dart SDK sdk/lib/svg/dart2js directory from the license c…
Browse files Browse the repository at this point in the history
…rawl (#49977)

This directory contains a file that is generated from other sources.

It is causing problems for the license script because it contains multiple copyright messages and one of the messages is partially included in the header region parsed by the script.
  • Loading branch information
jason-simmons committed Jan 23, 2024
1 parent 0b9b538 commit 945632e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions ci/licenses_golden/excluded_files
Original file line number Diff line number Diff line change
Expand Up @@ -2521,6 +2521,7 @@
../../../third_party/dart/sdk/lib/html/doc
../../../third_party/dart/sdk/lib/libraries.json
../../../third_party/dart/sdk/lib/libraries.yaml
../../../third_party/dart/sdk/lib/svg/dart2js
../../../third_party/dart/sdk/lib/vmservice_libraries.json
../../../third_party/dart/sdk/lib/vmservice_libraries.yaml
../../../third_party/dart/sdk/version
Expand Down
4 changes: 1 addition & 3 deletions ci/licenses_golden/licenses_dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Signature: 070d855e9daf0706a6209be7505b27e1
Signature: bfe079de7a6c5c5c2ce1f7e9837a17ac

====================================================================================================
LIBRARY: dart
Expand Down Expand Up @@ -857,7 +857,6 @@ ORIGIN: ../../../third_party/dart/sdk/lib/io/secure_server_socket.dart + ../../.
ORIGIN: ../../../third_party/dart/sdk/lib/isolate/isolate.dart + ../../../third_party/dart/LICENSE
ORIGIN: ../../../third_party/dart/sdk/lib/math/math.dart + ../../../third_party/dart/LICENSE
ORIGIN: ../../../third_party/dart/sdk/lib/math/random.dart + ../../../third_party/dart/LICENSE
ORIGIN: ../../../third_party/dart/sdk/lib/svg/dart2js/svg_dart2js.dart + ../../../third_party/dart/LICENSE
ORIGIN: ../../../third_party/dart/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart + ../../../third_party/dart/LICENSE
ORIGIN: ../../../third_party/dart/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart + ../../../third_party/dart/LICENSE
ORIGIN: ../../../third_party/dart/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart + ../../../third_party/dart/LICENSE
Expand Down Expand Up @@ -1225,7 +1224,6 @@ FILE: ../../../third_party/dart/sdk/lib/io/secure_server_socket.dart
FILE: ../../../third_party/dart/sdk/lib/isolate/isolate.dart
FILE: ../../../third_party/dart/sdk/lib/math/math.dart
FILE: ../../../third_party/dart/sdk/lib/math/random.dart
FILE: ../../../third_party/dart/sdk/lib/svg/dart2js/svg_dart2js.dart
FILE: ../../../third_party/dart/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
FILE: ../../../third_party/dart/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart
FILE: ../../../third_party/dart/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart
Expand Down
2 changes: 1 addition & 1 deletion ci/licenses_golden/tool_signature
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Signature: b0fbe71c20bdf5b2a1c163281b1f90de
Signature: f835ab00d16b708da196110898b39ac6

1 change: 1 addition & 0 deletions tools/licenses/lib/paths.dart
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ final Set<String> skippedPaths = <String>{
r'third_party/dart/runtime/docs',
r'third_party/dart/runtime/vm/service',
r'third_party/dart/sdk/lib/html/doc',
r'third_party/dart/sdk/lib/svg/dart2js', // generated from other sources
r'third_party/dart/third_party/binary_size', // not linked in
r'third_party/dart/third_party/binaryen', // not linked in
r'third_party/dart/third_party/d3', // Siva says "that is the charting library used by the binary size tool"
Expand Down

0 comments on commit 945632e

Please sign in to comment.