Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 8a29f14

Browse files
committed
Fix unit tests for FlutterEngine.spawn in iOS
1 parent 6e77f99 commit 8a29f14

File tree

5 files changed

+13
-5
lines changed

5 files changed

+13
-5
lines changed

shell/platform/darwin/ios/framework/Source/FlutterEngineTest.mm

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,10 @@ - (void)testWaitForFirstFrameTimeout {
194194
- (void)testSpawn {
195195
FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"foobar"];
196196
[engine run];
197-
FlutterEngine* spawn = [engine spawnWithEntrypoint:nil libraryURI:nil initialRoute:nil];
197+
FlutterEngine* spawn = [engine spawnWithEntrypoint:nil
198+
libraryURI:nil
199+
initialRoute:nil
200+
initialArguments:nil];
198201
XCTAssertNotNil(spawn);
199202
}
200203

shell/platform/darwin/ios/framework/Source/FlutterEngineTest_mrc.mm

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,10 @@ - (void)tearDown {
3838
- (void)testSpawnsShareGpuContext {
3939
FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"foobar"];
4040
[engine run];
41-
FlutterEngine* spawn = [engine spawnWithEntrypoint:nil libraryURI:nil initialRoute:nil];
41+
FlutterEngine* spawn = [engine spawnWithEntrypoint:nil
42+
libraryURI:nil
43+
initialRoute:nil
44+
initialArguments:nil];
4245
XCTAssertNotNil(spawn);
4346
XCTAssertTrue([engine iosPlatformView] != nullptr);
4447
XCTAssertTrue([spawn iosPlatformView] != nullptr);

shell/platform/darwin/ios/framework/Source/FlutterEngine_Test.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class ThreadHost;
2020
- (void)waitForFirstFrame:(NSTimeInterval)timeout callback:(void (^)(BOOL didTimeout))callback;
2121
- (FlutterEngine*)spawnWithEntrypoint:(/*nullable*/ NSString*)entrypoint
2222
libraryURI:(/*nullable*/ NSString*)libraryURI
23-
initialRoute:(/*nullable*/ NSString*)initialRoute;
23+
initialRoute:(/*nullable*/ NSString*)initialRoute
24+
initialArguments:(/*nullable*/ id)initialArguments;
2425
- (const flutter::ThreadHost&)threadHost;
2526
@end

testing/scenario_app/ios/Scenarios/Scenarios/AppDelegate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ - (FlutterEngine*)engineForTest:(NSString*)scenarioIdentifier {
9191
FlutterEngine* spawner = [[FlutterEngine alloc] initWithName:@"FlutterControllerTest"
9292
project:nil];
9393
[spawner run];
94-
return [spawner spawnWithEntrypoint:nil libraryURI:nil initialRoute:nil];
94+
return [spawner spawnWithEntrypoint:nil libraryURI:nil initialRoute:nil initialArguments:nil];
9595
} else {
9696
FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"FlutterControllerTest"
9797
project:nil];

testing/scenario_app/ios/Scenarios/Scenarios/FlutterEngine+ScenariosTest.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ NS_ASSUME_NONNULL_BEGIN
1010
withCompletion:(nullable void (^)(void))engineRunCompletion;
1111
- (FlutterEngine*)spawnWithEntrypoint:(nullable NSString*)entrypoint
1212
libraryURI:(nullable NSString*)libraryURI
13-
initialRoute:(nullable NSString*)initialRoute;
13+
initialRoute:(nullable NSString*)initialRoute
14+
initialArguments:(nullable id)initialArguments;
1415
@end
1516
NS_ASSUME_NONNULL_END

0 commit comments

Comments
 (0)