Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 845a09b

Browse files
ianelliottusCommit Bot
authored andcommitted
Vulkan: glDeleteTexture unbind all image texture units
The old code only unbound one image unit when a texture was deleted. The GLES specification is clear that the texture should be unbound from all units: If a texture object bound to one or more image units is deleted by DeleteTextures, it is detached from each such image unit, as though BindImageTexture were called with unit identifying the image unit and texture set to zero. Bug: angleproject:4310 Change-Id: I24c508660ad7eb3aa944601175803751b54ce0dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011322 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
1 parent 62475e9 commit 845a09b

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

src/libANGLE/State.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1232,7 +1232,6 @@ void State::detachTexture(const Context *context, const TextureMap &zeroTextures
12321232
bindingImageUnit.layer = 0;
12331233
bindingImageUnit.access = GL_READ_ONLY;
12341234
bindingImageUnit.format = GL_R32UI;
1235-
break;
12361235
}
12371236
}
12381237

src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060

6161
// Image related failures
6262

63-
4310 : KHR-GLES31.core.shader_image_load_store.basic-api-bind = FAIL
6463
4311 : KHR-GLES31.core.shader_image_load_store.basic-api-texParam = FAIL
6564
4314 : KHR-GLES31.core.shader_image_load_store.basic-glsl-earlyFragTests = FAIL
6665
4316 : KHR-GLES31.core.shader_image_load_store.negative-linkErrors = FAIL

0 commit comments

Comments
 (0)