Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 7ecd2d4

Browse files
author
Chris Yang
authored
Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test TwoPlatformViewsWithOtherBackDropFilterTests (#41532)
iPhone 8 is old and not installed by default with the latest XCodes. Move the scenario test to a newer iPhone that has a home button. (Unfortunately, iPhones without home button have the bottom navigation bar that animates, resulting inconsistency during screenshots) Fixes flutter/flutter#125167 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 3fa6084 commit 7ecd2d4

File tree

36 files changed

+83
-83
lines changed

36 files changed

+83
-83
lines changed

testing/scenario_app/ios/Scenarios/Scenarios.xcodeproj/project.pbxproj

Lines changed: 80 additions & 80 deletions
Large diffs are not rendered by default.

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewUITests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ - (instancetype)initWithInvocation:(NSInvocation*)invocation {
320320
return [super initWithManager:manager invocation:invocation];
321321
}
322322

323-
- (void)skip_testPlatformView {
323+
- (void)testPlatformView {
324324
[self checkPlatformViewGolden];
325325
}
326326

testing/scenario_app/run_ios_tests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ echo ""
4848

4949
set -o pipefail && xcodebuild -sdk iphonesimulator \
5050
-scheme Scenarios \
51-
-destination 'platform=iOS Simulator,OS=16.0,name=iPhone 8' \
51+
-destination 'platform=iOS Simulator,OS=16.2,name=iPhone SE (3rd generation)' \
5252
clean test \
5353
FLUTTER_ENGINE="$FLUTTER_ENGINE"
5454

@@ -58,7 +58,7 @@ echo ""
5858
# Skip testFontRenderingWhenSuppliedWithBogusFont: https://github.com/flutter/flutter/issues/113250
5959
set -o pipefail && xcodebuild -sdk iphonesimulator \
6060
-scheme Scenarios \
61-
-destination 'platform=iOS Simulator,OS=16.0,name=iPhone 8' \
61+
-destination 'platform=iOS Simulator,OS=16.2,name=iPhone SE (3rd generation)' \
6262
clean test \
6363
FLUTTER_ENGINE="$FLUTTER_ENGINE" \
6464
-skip-testing "ScenariosUITests/BogusFontTextTest/testFontRenderingWhenSuppliedWithBogusFont" \

0 commit comments

Comments
 (0)