[Impeller] disable surface control on API 29. (#55708)

Jonah Williams · web-flow · commit 772142e52853 · 2024-10-07T20:10:16.000Z
Fixes flutter/flutter#155877 Technically SurfaceControl is supported on API 29 but I've observed enough reported bugs that I'm bumping the constraint to 30. If we had more time to test all of these older devices maybe we could figure out if the problem is something that can be worked around.
diff --git a/impeller/toolkit/android/surface_control.cc b/impeller/toolkit/android/surface_control.cc
@@ -48,7 +48,14 @@ bool SurfaceControl::RemoveFromParent() const {
 }
 
 bool SurfaceControl::IsAvailableOnPlatform() {
-  return GetProcTable().IsValid() &&
+  auto api_level = android_get_device_api_level();
+
+  // Technically SurfaceControl is supported on API 29 but I've observed
+  // enough reported bugs that I'm bumping the constraint to 30. If
+  // we had more time to test all of these older devices maybe we could
+  // figure out what the problem is.
+  // https://github.com/flutter/flutter/issues/155877
+  return api_level >= 30 && GetProcTable().IsValid() &&
          GetProcTable().ASurfaceControl_createFromWindow.IsAvailable();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,14 @@ bool SurfaceControl::RemoveFromParent() const {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`bool SurfaceControl::IsAvailableOnPlatform() {`
`51`		`- return GetProcTable().IsValid() &&`
	`51`	`+ auto api_level = android_get_device_api_level();`
	`52`	`+`
	`53`	`+ // Technically SurfaceControl is supported on API 29 but I've observed`
	`54`	`+ // enough reported bugs that I'm bumping the constraint to 30. If`
	`55`	`+ // we had more time to test all of these older devices maybe we could`
	`56`	`+ // figure out what the problem is.`
	`57`	`+ // https://github.com/flutter/flutter/issues/155877`
	`58`	`+ return api_level >= 30 && GetProcTable().IsValid() &&`
`52`	`59`	`GetProcTable().ASurfaceControl_createFromWindow.IsAvailable();`
`53`	`60`	`}`
`54`	`61`