Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 742c780

Browse files
author
Jonah Williams
authored
[Impeller] disable blending in gaussian intermediate steps. (#51118)
Noticed this while working on the StC debugging. We can disable blending on all intermediate gaussian steps. I don't know how much of an impact this has in practice.
1 parent 85ab856 commit 742c780

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

impeller/entity/contents/filters/gaussian_blur_filter_contents.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@
1212
#include "impeller/entity/contents/content_context.h"
1313
#include "impeller/entity/texture_fill.frag.h"
1414
#include "impeller/entity/texture_fill.vert.h"
15-
#include "impeller/renderer/command.h"
1615
#include "impeller/renderer/render_pass.h"
17-
#include "impeller/renderer/texture_mipmap.h"
1816
#include "impeller/renderer/vertex_buffer_builder.h"
1917

2018
namespace impeller {
@@ -89,6 +87,7 @@ fml::StatusOr<RenderTarget> MakeDownsampleSubpass(
8987
pass.SetCommandLabel("Gaussian blur downsample");
9088
auto pipeline_options = OptionsFromPass(pass);
9189
pipeline_options.primitive_type = PrimitiveType::kTriangleStrip;
90+
pipeline_options.blend_mode = BlendMode::kSource;
9291
pass.SetPipeline(renderer.GetTexturePipeline(pipeline_options));
9392

9493
TextureFillVertexShader::FrameInfo frame_info;
@@ -150,6 +149,7 @@ fml::StatusOr<RenderTarget> MakeBlurSubpass(
150149

151150
ContentContextOptions options = OptionsFromPass(pass);
152151
options.primitive_type = PrimitiveType::kTriangleStrip;
152+
options.blend_mode = BlendMode::kSource;
153153

154154
if (tile_mode == Entity::TileMode::kDecal &&
155155
!renderer.GetDeviceCapabilities()

0 commit comments

Comments
 (0)