Remove kD24UNormS8UInt

Author: bdero

impeller/renderer/backend/gles/texture_gles.cc

@@ -109,7 +109,6 @@ struct TexImage2DData {
         break;
       case PixelFormat::kUnknown:
       case PixelFormat::kS8UInt:
-      case PixelFormat::kD24UNormS8UInt:
       case PixelFormat::kD32FloatS8UInt:
       case PixelFormat::kR8UNormInt:
       case PixelFormat::kR8G8UNormInt:
@@ -141,7 +140,6 @@ struct TexImage2DData {
       case PixelFormat::kB8G8R8A8UNormInt:
       case PixelFormat::kB8G8R8A8UNormIntSRGB:
       case PixelFormat::kS8UInt:
-      case PixelFormat::kD24UNormS8UInt:
       case PixelFormat::kD32FloatS8UInt:
       case PixelFormat::kR8UNormInt:
       case PixelFormat::kR8G8UNormInt:
@@ -278,8 +276,6 @@ static std::optional<GLenum> ToRenderBufferFormat(PixelFormat format) {
       return GL_RGBA4;
     case PixelFormat::kS8UInt:
       return GL_STENCIL_INDEX8;
-    case PixelFormat::kD24UNormS8UInt:
-      return GL_DEPTH24_STENCIL8;
     case PixelFormat::kD32FloatS8UInt:
       return GL_DEPTH32F_STENCIL8;
     case PixelFormat::kUnknown:

impeller/renderer/backend/metal/formats_mtl.h

@@ -31,8 +31,6 @@ constexpr PixelFormat FromMTLPixelFormat(MTLPixelFormat format) {
       return PixelFormat::kR8G8B8A8UNormIntSRGB;
     case MTLPixelFormatStencil8:
       return PixelFormat::kS8UInt;
-    case MTLPixelFormatDepth24Unorm_Stencil8:
-      return PixelFormat::kD24UNormS8UInt;
     case MTLPixelFormatDepth32Float_Stencil8:
       return PixelFormat::kD32FloatS8UInt;
     default:
@@ -61,8 +59,6 @@ constexpr MTLPixelFormat ToMTLPixelFormat(PixelFormat format) {
       return MTLPixelFormatRGBA8Unorm_sRGB;
     case PixelFormat::kS8UInt:
       return MTLPixelFormatStencil8;
-    case PixelFormat::kD24UNormS8UInt:
-      return MTLPixelFormatDepth24Unorm_Stencil8;
     case PixelFormat::kD32FloatS8UInt:
       return MTLPixelFormatDepth32Float_Stencil8;
   }

impeller/renderer/backend/vulkan/formats_vk.h

@@ -150,8 +150,6 @@ constexpr vk::Format ToVKImageFormat(PixelFormat format) {
       return vk::Format::eB8G8R8A8Srgb;
     case PixelFormat::kS8UInt:
       return vk::Format::eS8Uint;
-    case PixelFormat::kD24UNormS8UInt:
-      return vk::Format::eD24UnormS8Uint;
     case PixelFormat::kD32FloatS8UInt:
       return vk::Format::eD32SfloatS8Uint;
     case PixelFormat::kR8UNormInt:
@@ -183,9 +181,6 @@ constexpr PixelFormat ToPixelFormat(vk::Format format) {
     case vk::Format::eS8Uint:
       return PixelFormat::kS8UInt;
 
-    case vk::Format::eD24UnormS8Uint:
-      return PixelFormat::kD24UNormS8UInt;
-
     case vk::Format::eD32SfloatS8Uint:
       return PixelFormat::kD32FloatS8UInt;
 

impeller/renderer/formats.h

@@ -90,7 +90,6 @@ enum class PixelFormat {
 
   // Depth and stencil formats.
   kS8UInt,
-  kD24UNormS8UInt,
   kD32FloatS8UInt,
 
   // Defaults. If you don't know which ones to use, these are usually a safe
@@ -288,7 +287,6 @@ constexpr size_t BytesPerPixelForPixelFormat(PixelFormat format) {
     case PixelFormat::kR8G8B8A8UNormIntSRGB:
     case PixelFormat::kB8G8R8A8UNormInt:
     case PixelFormat::kB8G8R8A8UNormIntSRGB:
-    case PixelFormat::kD24UNormS8UInt:
       return 4u;
     case PixelFormat::kD32FloatS8UInt:
       return 5u;