Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 610640f

Browse files
null77Commit Bot
authored andcommitted
Don't use gl::Error in validation.
Instead pass error code and error message directly to the Context. As a side effect every validation error has an associated message now. Reduces binary size by almost 100k. Bug: angleproject:2957 Change-Id: I045e8ab57f8f9d787654a32f6f037011fe3a9f24 Reviewed-on: https://chromium-review.googlesource.com/c/1335890 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
1 parent dc65c5b commit 610640f

File tree

8 files changed

+2169
-1980
lines changed

8 files changed

+2169
-1980
lines changed

src/libANGLE/Error.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,6 @@ using ErrorStream = angle::ErrorStreamBase<Error, GLenum, GL_NO_ERROR, GLenum, E
9898

9999
} // namespace priv
100100

101-
using InvalidEnum = priv::ErrorStream<GL_INVALID_ENUM>;
102-
using InvalidValue = priv::ErrorStream<GL_INVALID_VALUE>;
103-
using InvalidOperation = priv::ErrorStream<GL_INVALID_OPERATION>;
104-
using StackOverflow = priv::ErrorStream<GL_STACK_OVERFLOW>;
105-
using StackUnderflow = priv::ErrorStream<GL_STACK_UNDERFLOW>;
106-
using OutOfMemory = priv::ErrorStream<GL_OUT_OF_MEMORY>;
107-
using InvalidFramebufferOperation = priv::ErrorStream<GL_INVALID_FRAMEBUFFER_OPERATION>;
108-
109101
inline Error NoError()
110102
{
111103
return Error::NoError();

src/libANGLE/ErrorStrings.h

Lines changed: 479 additions & 360 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)