Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 5f6dec8

Browse files
authored
Remove the view ID check in macOS/FlutterCompositor (#51852)
This PR removes the view ID check added in #51738, which has been causing a test `FlutterEngineTest.CompositorIgnoresUnknownView`, added in #51436, to fail. This problem was missed by the CI because the test and the view ID check were added in two PRs recently and they were not using the latest engine to check. The view ID check is not needed anyway, and is only a temporary check until the multiview support is landed. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 5dbcfdc commit 5f6dec8

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

shell/platform/darwin/macos/framework/Source/FlutterCompositor.mm

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,6 @@
5454
bool FlutterCompositor::Present(FlutterViewId view_id,
5555
const FlutterLayer** layers,
5656
size_t layers_count) {
57-
// TODO(dkwingsmt): The macOS embedder only supports rendering to the implicit
58-
// view for now. As it supports adding more views, this assertion should be
59-
// lifted. https://github.com/flutter/flutter/issues/142845
60-
FML_DCHECK(view_id == kFlutterImplicitViewId);
6157
FlutterView* view = [view_provider_ viewForId:view_id];
6258
if (!view) {
6359
return false;

0 commit comments

Comments
 (0)