Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 4f95695

Browse files
committed
[Impeller] Remove unused bounds method from typographer interface
1 parent 625ea53 commit 4f95695

File tree

3 files changed

+0
-23
lines changed

3 files changed

+0
-23
lines changed

impeller/typographer/backends/skia/typeface_skia.cc

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,6 @@ bool TypefaceSkia::IsEqual(const Typeface& other) const {
2828
return sk_other->typeface_ == typeface_;
2929
}
3030

31-
Rect TypefaceSkia::GetBoundingBox() const {
32-
if (!IsValid()) {
33-
return {};
34-
}
35-
36-
const auto bounds = typeface_->getBounds();
37-
38-
return Rect::MakeLTRB(bounds.left(), bounds.top(), bounds.right(),
39-
bounds.bottom());
40-
}
41-
4231
const sk_sp<SkTypeface>& TypefaceSkia::GetSkiaTypeface() const {
4332
return typeface_;
4433
}

impeller/typographer/backends/skia/typeface_skia.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ class TypefaceSkia final : public Typeface,
2828
// |Comparable<Typeface>|
2929
bool IsEqual(const Typeface& other) const override;
3030

31-
// |Typeface|
32-
Rect GetBoundingBox() const override;
33-
3431
const sk_sp<SkTypeface>& GetSkiaTypeface() const;
3532

3633
private:

impeller/typographer/typeface.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,6 @@ class Typeface : public Comparable<Typeface> {
2424

2525
virtual bool IsValid() const = 0;
2626

27-
//----------------------------------------------------------------------------
28-
/// @brief Get the union of the bounding boxes of all glyphs in the
29-
/// typeface. This box is unit-scaled and conservatively large to
30-
/// cover all glyphs.
31-
///
32-
/// @return The conservative unit-scaled bounding box.
33-
///
34-
virtual Rect GetBoundingBox() const = 0;
35-
3627
private:
3728
FML_DISALLOW_COPY_AND_ASSIGN(Typeface);
3829
};

0 commit comments

Comments
 (0)