Move CircleTessellator to tessellator dir and move cache to Tessellator instance

Author: flar

ci/licenses_golden/excluded_files

@@ -147,7 +147,6 @@
 ../../../flutter/impeller/entity/contents/vertices_contents_unittests.cc
 ../../../flutter/impeller/entity/entity_pass_target_unittests.cc
 ../../../flutter/impeller/entity/entity_unittests.cc
-../../../flutter/impeller/entity/geometry/circle_tessellator_unittests.cc
 ../../../flutter/impeller/entity/geometry/geometry_unittests.cc
 ../../../flutter/impeller/entity/render_target_cache_unittests.cc
 ../../../flutter/impeller/fixtures
@@ -157,6 +156,7 @@
 ../../../flutter/impeller/geometry/path_unittests.cc
 ../../../flutter/impeller/geometry/rect_unittests.cc
 ../../../flutter/impeller/geometry/size_unittests.cc
+../../../flutter/impeller/geometry/trig_unittests.cc
 ../../../flutter/impeller/golden_tests/README.md
 ../../../flutter/impeller/golden_tests_harvester/.dart_tool
 ../../../flutter/impeller/golden_tests_harvester/.gitignore
@@ -194,6 +194,7 @@
 ../../../flutter/impeller/scene/importer/importer_unittests.cc
 ../../../flutter/impeller/scene/scene_unittests.cc
 ../../../flutter/impeller/shader_archive/shader_archive_unittests.cc
+../../../flutter/impeller/tessellator/circle_tessellator_unittests.cc
 ../../../flutter/impeller/tessellator/dart/.dart_tool
 ../../../flutter/impeller/tessellator/dart/pubspec.lock
 ../../../flutter/impeller/tessellator/dart/pubspec.yaml

ci/licenses_golden/licenses_flutter

@@ -5099,8 +5099,6 @@ ORIGIN: ../../../flutter/impeller/entity/entity_pass_target.cc + ../../../flutte
 ORIGIN: ../../../flutter/impeller/entity/entity_pass_target.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/entity_playground.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/entity_playground.h + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/entity/geometry/circle_tessellator.cc + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/entity/geometry/circle_tessellator.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/geometry/cover_geometry.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/geometry/cover_geometry.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/entity/geometry/ellipse_geometry.cc + ../../../flutter/LICENSE
@@ -5210,6 +5208,8 @@ ORIGIN: ../../../flutter/impeller/geometry/sigma.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/geometry/sigma.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/geometry/size.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/geometry/size.h + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/impeller/geometry/trig.cc + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/impeller/geometry/trig.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/geometry/type_traits.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/geometry/type_traits.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/geometry/vector.cc + ../../../flutter/LICENSE
@@ -5527,6 +5527,8 @@ ORIGIN: ../../../flutter/impeller/shader_archive/shader_archive_writer.cc + ../.
 ORIGIN: ../../../flutter/impeller/shader_archive/shader_archive_writer.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/tessellator/c/tessellator.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/tessellator/c/tessellator.h + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/impeller/tessellator/circle_tessellator.cc + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/impeller/tessellator/circle_tessellator.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/tessellator/dart/lib/tessellator.dart + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/tessellator/tessellator.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/tessellator/tessellator.h + ../../../flutter/LICENSE
@@ -7895,8 +7897,6 @@ FILE: ../../../flutter/impeller/entity/entity_pass_target.cc
 FILE: ../../../flutter/impeller/entity/entity_pass_target.h
 FILE: ../../../flutter/impeller/entity/entity_playground.cc
 FILE: ../../../flutter/impeller/entity/entity_playground.h
-FILE: ../../../flutter/impeller/entity/geometry/circle_tessellator.cc
-FILE: ../../../flutter/impeller/entity/geometry/circle_tessellator.h
 FILE: ../../../flutter/impeller/entity/geometry/cover_geometry.cc
 FILE: ../../../flutter/impeller/entity/geometry/cover_geometry.h
 FILE: ../../../flutter/impeller/entity/geometry/ellipse_geometry.cc
@@ -8006,6 +8006,8 @@ FILE: ../../../flutter/impeller/geometry/sigma.cc
 FILE: ../../../flutter/impeller/geometry/sigma.h
 FILE: ../../../flutter/impeller/geometry/size.cc
 FILE: ../../../flutter/impeller/geometry/size.h
+FILE: ../../../flutter/impeller/geometry/trig.cc
+FILE: ../../../flutter/impeller/geometry/trig.h
 FILE: ../../../flutter/impeller/geometry/type_traits.cc
 FILE: ../../../flutter/impeller/geometry/type_traits.h
 FILE: ../../../flutter/impeller/geometry/vector.cc
@@ -8324,6 +8326,8 @@ FILE: ../../../flutter/impeller/shader_archive/shader_archive_writer.cc
 FILE: ../../../flutter/impeller/shader_archive/shader_archive_writer.h
 FILE: ../../../flutter/impeller/tessellator/c/tessellator.cc
 FILE: ../../../flutter/impeller/tessellator/c/tessellator.h
+FILE: ../../../flutter/impeller/tessellator/circle_tessellator.cc
+FILE: ../../../flutter/impeller/tessellator/circle_tessellator.h
 FILE: ../../../flutter/impeller/tessellator/dart/lib/tessellator.dart
 FILE: ../../../flutter/impeller/tessellator/tessellator.cc
 FILE: ../../../flutter/impeller/tessellator/tessellator.h

impeller/entity/BUILD.gn

@@ -191,8 +191,6 @@ impeller_component("entity") {
     "entity_pass_delegate.h",
     "entity_pass_target.cc",
     "entity_pass_target.h",
-    "geometry/circle_tessellator.cc",
-    "geometry/circle_tessellator.h",
     "geometry/cover_geometry.cc",
     "geometry/cover_geometry.h",
     "geometry/ellipse_geometry.cc",
@@ -270,7 +268,6 @@ impeller_component("entity_unittests") {
     "entity_playground.cc",
     "entity_playground.h",
     "entity_unittests.cc",
-    "geometry/circle_tessellator_unittests.cc",
     "geometry/geometry_unittests.cc",
     "render_target_cache_unittests.cc",
   ]

impeller/entity/geometry/circle_tessellator.cc

@@ -4,7 +4,7 @@
 
 #include "impeller/entity/geometry/ellipse_geometry.h"
 
-#include "flutter/impeller/entity/geometry/circle_tessellator.h"
+#include "flutter/impeller/tessellator/circle_tessellator.h"
 
 namespace impeller {
 
@@ -22,7 +22,8 @@ GeometryResult EllipseGeometry::GetPositionBuffer(
 
   Scalar radius = radius_;
   const Point& center = center_;
-  CircleTessellator tessellator(entity.GetTransform(), radius_);
+  std::shared_ptr<Tessellator> t = renderer.GetTessellator();
+  CircleTessellator tessellator(t, entity.GetTransform(), radius_);
   size_t count = tessellator.GetCircleVertexCount();
   auto vertex_buffer =
       host_buffer.Emplace(count * sizeof(VT), alignof(VT),
@@ -65,7 +66,8 @@ GeometryResult EllipseGeometry::GetPositionUVBuffer(
 
   Scalar radius = radius_;
   const Point& center = center_;
-  CircleTessellator tessellator(entity.GetTransform(), radius_);
+  std::shared_ptr<Tessellator> t = renderer.GetTessellator();
+  CircleTessellator tessellator(t, entity.GetTransform(), radius_);
   size_t count = tessellator.GetCircleVertexCount();
   auto vertex_buffer = host_buffer.Emplace(
       count * sizeof(VT), alignof(VT),

impeller/entity/geometry/circle_tessellator_unittests.cc

@@ -4,7 +4,7 @@
 
 #include "impeller/entity/geometry/line_geometry.h"
 
-#include "flutter/impeller/entity/geometry/circle_tessellator.h"
+#include "flutter/impeller/tessellator/circle_tessellator.h"
 
 namespace impeller {
 
@@ -80,7 +80,8 @@ GeometryResult LineGeometry::GetPositionBuffer(const ContentContext& renderer,
     const Point& p0 = p0_;
     const Point& p1 = p1_;
 
-    CircleTessellator tessellator(transform, radius);
+    std::shared_ptr<Tessellator> t = renderer.GetTessellator();
+    CircleTessellator tessellator(t, entity.GetTransform(), radius);
     count = tessellator.GetCircleVertexCount();
     vertex_buffer =
         host_buffer.Emplace(count * sizeof(VT), alignof(VT),
@@ -147,7 +148,8 @@ GeometryResult LineGeometry::GetPositionUVBuffer(Rect texture_coverage,
     const Point& p0 = p0_;
     const Point& p1 = p1_;
 
-    CircleTessellator tessellator(transform, radius);
+    std::shared_ptr<Tessellator> t = renderer.GetTessellator();
+    CircleTessellator tessellator(t, entity.GetTransform(), radius);
     count = tessellator.GetCircleVertexCount();
     vertex_buffer = host_buffer.Emplace(
         count * sizeof(VT), alignof(VT),