Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 49d11cd

Browse files
authored
[flatland] Update bug numbers. (#37880)
1 parent 9b28957 commit 49d11cd

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

shell/platform/fuchsia/flutter/engine.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ void Engine::Terminate() {
744744
void Engine::DebugWireframeSettingsChanged(bool enabled) {
745745
FML_CHECK(shell_);
746746

747-
// TODO(fxbug.dev/94000): Investigate if we can add flatland wireframe code
747+
// TODO(fxbug.dev/116000): Investigate if we can add flatland wireframe code
748748
// for debugging.
749749
shell_->GetTaskRunners().GetRasterTaskRunner()->PostTask([this, enabled]() {
750750
if (external_view_embedder_) {

shell/platform/fuchsia/flutter/flatland_connection.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ void FlatlandConnection::DoPresent() {
5454
--present_credits_;
5555

5656
fuchsia::ui::composition::PresentArgs present_args;
57-
// TODO(fxbug.dev/94000): compute a better presentation time;
57+
// TODO(fxbug.dev/114588): compute a better presentation time;
5858
present_args.set_requested_presentation_time(0);
5959
present_args.set_acquire_fences(std::move(acquire_fences_));
6060
present_args.set_release_fences(std::move(previous_present_release_fences_));
@@ -86,7 +86,7 @@ void FlatlandConnection::AwaitVsync(FireCallbackCallback callback) {
8686

8787
if (threadsafe_state_.fire_callback_pending_) {
8888
fml::TimePoint now = fml::TimePoint::Now();
89-
// TODO(fxbug.dev/94000): Calculate correct frame times.
89+
// TODO(fxbug.dev/114588): Calculate correct frame times.
9090
threadsafe_state_.fire_callback_(
9191
now, now + kDefaultFlatlandPresentationInterval);
9292
threadsafe_state_.fire_callback_ = nullptr;
@@ -121,7 +121,7 @@ void FlatlandConnection::OnNextFrameBegin(
121121
std::scoped_lock<std::mutex> lock(threadsafe_state_.mutex_);
122122
if (threadsafe_state_.fire_callback_) {
123123
fml::TimePoint now = fml::TimePoint::Now();
124-
// TODO(fxbug.dev/94000): Calculate correct frame times.
124+
// TODO(fxbug.dev/114588): Calculate correct frame times.
125125
threadsafe_state_.fire_callback_(
126126
now, now + kDefaultFlatlandPresentationInterval);
127127
threadsafe_state_.fire_callback_ = nullptr;

shell/platform/fuchsia/flutter/flatland_external_view_embedder.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,6 @@ void FlatlandExternalViewEmbedder::SubmitFrame(
288288
viewport.mutators.transform = view_mutators.transform;
289289
}
290290

291-
// TODO(fxbug.dev/94000): Set HitTestBehavior.
292-
293291
// Set clip regions.
294292
if (view_mutators.clips != viewport.mutators.clips) {
295293
// Expand the clip_transforms array to fit any new transforms.

shell/platform/fuchsia/flutter/flatland_platform_view.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ void FlatlandPlatformView::OnGetLayout(
113113

114114
void FlatlandPlatformView::OnParentViewportStatus(
115115
fuchsia::ui::composition::ParentViewportStatus status) {
116-
// TODO(fxbug.dev/94000): Investigate if it is useful to send hidden/shown
116+
// TODO(fxbug.dev/116001): Investigate if it is useful to send hidden/shown
117117
// signals.
118118
parent_viewport_status_ = status;
119119
parent_viewport_watcher_->GetStatus(

0 commit comments

Comments
 (0)