Do not retry lint or clang tidy tests. (#42498)

godofredoc · web-flow · commit 461f14c768c9 · 2023-06-01T23:48:20.000Z
Retries on lints and clang tidy were hiding the issues as timeouts rather than providing the fail signal right away. Bug: flutter/flutter#128083 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
diff --git a/ci/builders/linux_clang_tidy.json b/ci/builders/linux_clang_tidy.json
@@ -61,6 +61,7 @@
                         "--shard-id=1",
                         "--shard-variants=android_debug_arm64"
                     ],
+		    "max_attempts": 1,
                     "script": "flutter/ci/lint.sh"
                 }
             ]
@@ -86,6 +87,7 @@
                         "--shard-id=0",
                         "--shard-variants=host_debug"
                     ],
+		    "max_attempts": 1,
                     "script": "flutter/ci/lint.sh"
                 }
             ]
diff --git a/ci/builders/mac_clang_tidy.json b/ci/builders/mac_clang_tidy.json
@@ -70,6 +70,7 @@
                         "--shard-id=1",
                         "--shard-variants=ios_debug_sim"
                     ],
+		    "max_attempts": 1,
                     "script": "flutter/ci/lint.sh"
                 }
             ]
@@ -99,6 +100,7 @@
                         "--shard-id=0",
                         "--shard-variants=host_debug"
                     ],
+		    "max_attempts": 1,
                     "script": "flutter/ci/lint.sh"
                 }
             ]
diff --git a/ci/builders/standalone/linux_license.json b/ci/builders/standalone/linux_license.json
@@ -11,6 +11,7 @@
     "tests": [
         {
             "name": "licenses check",
+	    "max_attempts": 1,
             "script": "flutter/ci/licenses.sh"
         }
     ]

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@`
`61`	`61`	`"--shard-id=1",`
`62`	`62`	`"--shard-variants=android_debug_arm64"`
`63`	`63`	`],`
	`64`	`+ "max_attempts": 1,`
`64`	`65`	`"script": "flutter/ci/lint.sh"`
`65`	`66`	`}`
`66`	`67`	`]`
`@@ -86,6 +87,7 @@`
`86`	`87`	`"--shard-id=0",`
`87`	`88`	`"--shard-variants=host_debug"`
`88`	`89`	`],`
	`90`	`+ "max_attempts": 1,`
`89`	`91`	`"script": "flutter/ci/lint.sh"`
`90`	`92`	`}`
`91`	`93`	`]`
Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@`
`70`	`70`	`"--shard-id=1",`
`71`	`71`	`"--shard-variants=ios_debug_sim"`
`72`	`72`	`],`
	`73`	`+ "max_attempts": 1,`
`73`	`74`	`"script": "flutter/ci/lint.sh"`
`74`	`75`	`}`
`75`	`76`	`]`
`@@ -99,6 +100,7 @@`
`99`	`100`	`"--shard-id=0",`
`100`	`101`	`"--shard-variants=host_debug"`
`101`	`102`	`],`
	`103`	`+ "max_attempts": 1,`
`102`	`104`	`"script": "flutter/ci/lint.sh"`
`103`	`105`	`}`
`104`	`106`	`]`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`"tests": [`
`12`	`12`	`{`
`13`	`13`	`"name": "licenses check",`
	`14`	`+ "max_attempts": 1,`
`14`	`15`	`"script": "flutter/ci/licenses.sh"`
`15`	`16`	`}`
`16`	`17`	`]`