[vm/precomp] Reduce arm32 code size for BoxInt64Instr

Change-Id: I018ddd6add8b8ff447019cc61bff579104084f00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128072
Commit-Queue: Victor Agnez Lima <victoragnez@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

Author: victoragnez

runtime/vm/compiler/aot/precompiler.cc

@@ -295,6 +295,15 @@ void Precompiler::DoCompileAll() {
                 global_object_pool_builder());
         I->object_store()->set_null_error_stub_without_fpu_regs_stub(stub_code);
 
+        stub_code = StubCode::BuildIsolateSpecificAllocateMintWithFPURegsStub(
+            global_object_pool_builder());
+        I->object_store()->set_allocate_mint_with_fpu_regs_stub(stub_code);
+
+        stub_code =
+            StubCode::BuildIsolateSpecificAllocateMintWithoutFPURegsStub(
+                global_object_pool_builder());
+        I->object_store()->set_allocate_mint_without_fpu_regs_stub(stub_code);
+
         stub_code =
             StubCode::BuildIsolateSpecificStackOverflowSharedWithFPURegsStub(
                 global_object_pool_builder());

runtime/vm/compiler/backend/flow_graph_compiler.h

@@ -847,6 +847,7 @@ class FlowGraphCompiler : public ValueObject {
   bool IsEmptyBlock(BlockEntryInstr* block) const;
 
  private:
+  friend class BoxInt64Instr;            // For AddPcRelativeCallStubTarget().
   friend class CheckNullInstr;           // For AddPcRelativeCallStubTarget().
   friend class NullErrorSlowPath;        // For AddPcRelativeCallStubTarget().
   friend class CheckStackOverflowInstr;  // For AddPcRelativeCallStubTarget().

runtime/vm/compiler/backend/il_arm.cc

@@ -4635,21 +4635,19 @@ void BoxInt64Instr::EmitNativeCode(FlowGraphCompiler* compiler) {
     __ TryAllocate(compiler->mint_class(),
                    compiler->intrinsic_slow_path_label(), out_reg, tmp);
   } else {
-    if (locs()->call_on_shared_slow_path()) {
-      const bool live_fpu_regs =
-          locs()->live_registers()->FpuRegisterCount() > 0;
-      __ ldr(
-          TMP,
-          compiler::Address(
-              THR,
-              live_fpu_regs
-                  ? compiler::target::Thread::
-                        allocate_mint_with_fpu_regs_entry_point_offset()
-                  : compiler::target::Thread::
-                        allocate_mint_without_fpu_regs_entry_point_offset()));
-      __ blx(TMP);
+    auto object_store = compiler->isolate()->object_store();
+    const bool live_fpu_regs = locs()->live_registers()->FpuRegisterCount() > 0;
+    const auto& stub = Code::ZoneHandle(
+        compiler->zone(),
+        live_fpu_regs ? object_store->allocate_mint_with_fpu_regs_stub()
+                      : object_store->allocate_mint_without_fpu_regs_stub());
+
+    if (locs()->call_on_shared_slow_path() && !stub.InVMIsolateHeap()) {
+      compiler->AddPcRelativeCallStubTarget(stub);
+      __ GenerateUnRelocatedPcRelativeCall();
 
       ASSERT(!locs()->live_registers()->ContainsRegister(R0));
+
       auto extended_env = compiler->SlowPathEnvironmentFor(this, 0);
       compiler->EmitCallsiteMetadata(token_pos(), DeoptId::kNone,
                                      RawPcDescriptors::kOther, locs(),

runtime/vm/image_snapshot.cc

@@ -478,6 +478,11 @@ static const char* NameOfStubIsolateSpecificStub(ObjectStore* object_store,
   } else if (code.raw() ==
              object_store->null_error_stub_without_fpu_regs_stub()) {
     return "_iso_stub_NullErrorSharedWithoutFPURegsStub";
+  } else if (code.raw() == object_store->allocate_mint_with_fpu_regs_stub()) {
+    return "_iso_stub_AllocateMintWithFPURegsStub";
+  } else if (code.raw() ==
+             object_store->allocate_mint_without_fpu_regs_stub()) {
+    return "_iso_stub_AllocateMintWithoutFPURegsStub";
   } else if (code.raw() ==
              object_store->stack_overflow_stub_with_fpu_regs_stub()) {
     return "_iso_stub_StackOverflowStubWithFPURegsStub";

runtime/vm/object_store.h

@@ -136,6 +136,8 @@ class ObjectPointerVisitor;
   RW(Code, build_method_extractor_code)                                        \
   RW(Code, null_error_stub_with_fpu_regs_stub)                                 \
   RW(Code, null_error_stub_without_fpu_regs_stub)                              \
+  RW(Code, allocate_mint_with_fpu_regs_stub)                                   \
+  RW(Code, allocate_mint_without_fpu_regs_stub)                                \
   RW(Code, stack_overflow_stub_with_fpu_regs_stub)                             \
   RW(Code, stack_overflow_stub_without_fpu_regs_stub)                          \
   RW(Code, write_barrier_wrappers_stub)                                        \