Reland fuchsia external view embedder will be shared with platform view (#22008)

* Reland fuchsia external view embedder will be shared with platform view

This reverts commit 9b75279.

* wait for the external view embedder to be initialized before creating
shell

Author: iskakaushik

flow/layers/child_scene_layer.cc

@@ -24,10 +24,10 @@ void ChildSceneLayer::Preroll(PrerollContext* context, const SkMatrix& matrix) {
 
 void ChildSceneLayer::Paint(PaintContext& context) const {}
 
-void ChildSceneLayer::UpdateScene(SceneUpdateContext& context) {
+void ChildSceneLayer::UpdateScene(std::shared_ptr<SceneUpdateContext> context) {
   TRACE_EVENT0("flutter", "ChildSceneLayer::UpdateScene");
   FML_DCHECK(needs_system_composite());
-  context.UpdateView(layer_id_, offset_, size_, hit_testable_);
+  context->UpdateView(layer_id_, offset_, size_, hit_testable_);
 }
 
 }  // namespace flutter

flow/layers/child_scene_layer.h

@@ -26,7 +26,7 @@ class ChildSceneLayer : public Layer {
 
   void Paint(PaintContext& context) const override;
 
-  void UpdateScene(SceneUpdateContext& context) override;
+  void UpdateScene(std::shared_ptr<SceneUpdateContext> context) override;
 
  private:
   zx_koid_t layer_id_ = ZX_KOID_INVALID;

flow/layers/clip_path_layer.cc

@@ -41,7 +41,7 @@ void ClipPathLayer::Preroll(PrerollContext* context, const SkMatrix& matrix) {
 
 #if defined(LEGACY_FUCHSIA_EMBEDDER)
 
-void ClipPathLayer::UpdateScene(SceneUpdateContext& context) {
+void ClipPathLayer::UpdateScene(std::shared_ptr<SceneUpdateContext> context) {
   TRACE_EVENT0("flutter", "ClipPathLayer::UpdateScene");
   FML_DCHECK(needs_system_composite());
 

flow/layers/clip_path_layer.h

@@ -22,7 +22,7 @@ class ClipPathLayer : public ContainerLayer {
   }
 
 #if defined(LEGACY_FUCHSIA_EMBEDDER)
-  void UpdateScene(SceneUpdateContext& context) override;
+  void UpdateScene(std::shared_ptr<SceneUpdateContext> context) override;
 #endif
 
  private:

flow/layers/clip_rect_layer.cc

@@ -36,7 +36,7 @@ void ClipRectLayer::Preroll(PrerollContext* context, const SkMatrix& matrix) {
 
 #if defined(LEGACY_FUCHSIA_EMBEDDER)
 
-void ClipRectLayer::UpdateScene(SceneUpdateContext& context) {
+void ClipRectLayer::UpdateScene(std::shared_ptr<SceneUpdateContext> context) {
   TRACE_EVENT0("flutter", "ClipRectLayer::UpdateScene");
   FML_DCHECK(needs_system_composite());
 

flow/layers/clip_rect_layer.h

@@ -21,7 +21,7 @@ class ClipRectLayer : public ContainerLayer {
   }
 
 #if defined(LEGACY_FUCHSIA_EMBEDDER)
-  void UpdateScene(SceneUpdateContext& context) override;
+  void UpdateScene(std::shared_ptr<SceneUpdateContext> context) override;
 #endif
 
  private:

flow/layers/clip_rrect_layer.cc

@@ -37,7 +37,7 @@ void ClipRRectLayer::Preroll(PrerollContext* context, const SkMatrix& matrix) {
 
 #if defined(LEGACY_FUCHSIA_EMBEDDER)
 
-void ClipRRectLayer::UpdateScene(SceneUpdateContext& context) {
+void ClipRRectLayer::UpdateScene(std::shared_ptr<SceneUpdateContext> context) {
   TRACE_EVENT0("flutter", "ClipRRectLayer::UpdateScene");
   FML_DCHECK(needs_system_composite());
 

flow/layers/clip_rrect_layer.h

@@ -22,7 +22,7 @@ class ClipRRectLayer : public ContainerLayer {
   }
 
 #if defined(LEGACY_FUCHSIA_EMBEDDER)
-  void UpdateScene(SceneUpdateContext& context) override;
+  void UpdateScene(std::shared_ptr<SceneUpdateContext> context) override;
 #endif
 
  private:

flow/layers/container_layer.cc

@@ -98,18 +98,19 @@ void ContainerLayer::CheckForChildLayerBelow(PrerollContext* context) {
   // All ContainerLayers make the check in PrerollChildren.
 }
 
-void ContainerLayer::UpdateScene(SceneUpdateContext& context) {
+void ContainerLayer::UpdateScene(std::shared_ptr<SceneUpdateContext> context) {
   UpdateSceneChildren(context);
 }
 
-void ContainerLayer::UpdateSceneChildren(SceneUpdateContext& context) {
+void ContainerLayer::UpdateSceneChildren(
+    std::shared_ptr<SceneUpdateContext> context) {
   FML_DCHECK(needs_system_composite());
 
   std::optional<SceneUpdateContext::Frame> frame;
   if (child_layer_exists_below_) {
     frame.emplace(
         context, SkRRect::MakeRect(paint_bounds()), SK_ColorTRANSPARENT,
-        SkScalarRoundToInt(context.alphaf() * 255), "flutter::ContainerLayer");
+        SkScalarRoundToInt(context->alphaf() * 255), "flutter::ContainerLayer");
     frame->AddPaintLayer(this);
   }
 

flow/layers/container_layer.h

@@ -21,7 +21,7 @@ class ContainerLayer : public Layer {
   void Paint(PaintContext& context) const override;
 #if defined(LEGACY_FUCHSIA_EMBEDDER)
   void CheckForChildLayerBelow(PrerollContext* context) override;
-  void UpdateScene(SceneUpdateContext& context) override;
+  void UpdateScene(std::shared_ptr<SceneUpdateContext> context) override;
 #endif
 
   const std::vector<std::shared_ptr<Layer>>& layers() const { return layers_; }
@@ -33,7 +33,7 @@ class ContainerLayer : public Layer {
   void PaintChildren(PaintContext& context) const;
 
 #if defined(LEGACY_FUCHSIA_EMBEDDER)
-  void UpdateSceneChildren(SceneUpdateContext& context);
+  void UpdateSceneChildren(std::shared_ptr<SceneUpdateContext> context);
 #endif
 
   // Try to prepare the raster cache for a given layer.