Refactor: fix typo "setup" -> "set up" (#43824)

There are several places in the engine using the word "setup" incorrectly. I have changed them to "set up"

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Author: Chris Yang

impeller/docs/read_frame_captures.md

@@ -211,7 +211,7 @@ function pipeline configuration.
 
 ![alt_text](assets/read_frame_captures/image7.png "image_tooltip")
 
-You will get intimately familiar with this view when you setup a new pipeline
+You will get intimately familiar with this view when you set up a new pipeline
 state object in Impeller or try to reason about the correctness of one of the
 pipeline state object variants.
 

impeller/docs/renderdoc_frame_capture.md

@@ -2,7 +2,7 @@
 
 [RenderDoc](https://renderdoc.org/) is a graphics debugger that can be used to capture frames. With Impeller starting to support gles and Vulkan backends, RenderDoc can provide insights into the application's frames.
 
-1. First step is to setup RenderDoc. Follow the instructions [here](https://renderdoc.org/docs/getting_started/quick_start.html). For the purposes of this guide it is assumed that you are able to get RenderDoc running.
+1. First step is to set up RenderDoc. Follow the instructions [here](https://renderdoc.org/docs/getting_started/quick_start.html). For the purposes of this guide it is assumed that you are able to get RenderDoc running.
 2. The next step would be to run the application you wish the capture the frames of. Typically these would be one of the playground tests. To build these, do:
 
 ```bash

impeller/docs/xcode_frame_capture.md

@@ -89,7 +89,7 @@ that some of those diagnostics need Xcode to be able to re-compile the
 translation units in the engine. But, it doesn’t know how to do that, only
 GN/Ninja does. So some of those will be unavailable.
 
-Any Impeller test that setup up a Playground will now automatically have GPU
+Any Impeller test that sets up a Playground will now automatically have GPU
 frame capture enabled.
 
 # Select the Playground Enabled Test to Profile

impeller/playground/backend/vulkan/playground_impl_vk.cc

@@ -108,7 +108,7 @@ PlaygroundImplVK::PlaygroundImplVK(PlaygroundSwitches switches)
 
   vk::UniqueSurfaceKHR surface{vk_surface, context->GetInstance()};
   if (!context->SetWindowSurface(std::move(surface))) {
-    VALIDATION_LOG << "Could not setup surface for context.";
+    VALIDATION_LOG << "Could not set up surface for context.";
     return;
   }
 

impeller/playground/playground.cc

@@ -125,8 +125,8 @@ void Playground::SetupContext(PlaygroundBackend backend) {
 
 void Playground::SetupWindow() {
   if (!context_) {
-    FML_LOG(WARNING)
-        << "Asked to setup a window with no context (call SetupContext first).";
+    FML_LOG(WARNING) << "Asked to set up a window with no context (call "
+                        "SetupContext first).";
     return;
   }
   auto renderer = std::make_unique<Renderer>(context_);

impeller/renderer/backend/metal/context_mtl.mm

@@ -79,7 +79,7 @@ static bool DeviceSupportsComputeSubgroups(id<MTLDevice> device) {
       is_gpu_disabled_sync_switch_(std::move(is_gpu_disabled_sync_switch)) {
   // Validate device.
   if (!device_) {
-    VALIDATION_LOG << "Could not setup valid Metal device.";
+    VALIDATION_LOG << "Could not set up valid Metal device.";
     return;
   }
 
@@ -135,7 +135,7 @@ static bool DeviceSupportsComputeSubgroups(id<MTLDevice> device) {
     resource_allocator_ = std::shared_ptr<AllocatorMTL>(
         new AllocatorMTL(device_, "Impeller Permanents Allocator"));
     if (!resource_allocator_) {
-      VALIDATION_LOG << "Could not setup the resource allocator.";
+      VALIDATION_LOG << "Could not set up the resource allocator.";
       return;
     }
   }
@@ -219,7 +219,7 @@ static bool DeviceSupportsComputeSubgroups(id<MTLDevice> device) {
 static id<MTLCommandQueue> CreateMetalCommandQueue(id<MTLDevice> device) {
   auto command_queue = device.newCommandQueue;
   if (!command_queue) {
-    VALIDATION_LOG << "Could not setup the command queue.";
+    VALIDATION_LOG << "Could not set up the command queue.";
     return nullptr;
   }
   command_queue.label = @"Impeller Command Queue";

impeller/renderer/backend/vulkan/context_vk.cc

@@ -227,7 +227,7 @@ void ContextVK::Setup(Settings settings) {
       std::make_unique<DebugReportVK>(*caps, device_holder->instance.get());
 
   if (!debug_report->IsValid()) {
-    VALIDATION_LOG << "Could not setup debug report.";
+    VALIDATION_LOG << "Could not set up debug report.";
     return;
   }
 
@@ -417,7 +417,7 @@ void ContextVK::Setup(Settings settings) {
 
   //----------------------------------------------------------------------------
   /// Label all the relevant objects. This happens after setup so that the debug
-  /// messengers have had a chance to be setup.
+  /// messengers have had a chance to be set up.
   ///
   SetDebugName(GetDevice(), device_holder_->device.get(), "ImpellerDevice");
 }

impeller/renderer/backend/vulkan/queue_vk.cc

@@ -43,7 +43,7 @@ QueuesVK::QueuesVK(const vk::Device& device,
   auto vk_compute = device.getQueue(compute.family, compute.index);
   auto vk_transfer = device.getQueue(transfer.family, transfer.index);
 
-  // Always setup the graphics queue.
+  // Always set up the graphics queue.
   graphics_queue = std::make_shared<QueueVK>(graphics, vk_graphics);
   ContextVK::SetDebugName(device, vk_graphics, "ImpellerGraphicsQ");
 

impeller/renderer/command_buffer.h

@@ -34,7 +34,7 @@ class CommandBufferMock;
 ///
 ///             A command buffer is only meant to be used on a single thread. If
 ///             a frame workload needs to be encoded from multiple threads,
-///             setup and record into multiple command buffers. The order of
+///             set up and record into multiple command buffers. The order of
 ///             submission of commands encoded in multiple command buffers can
 ///             be controlled via either the order in which the command buffers
 ///             were created, or, using the `ReserveSpotInQueue` command which

lib/ui/painting/image_decoder_unittests.cc

@@ -406,12 +406,12 @@ TEST_F(ImageDecoderFixtureTest, ValidImageResultsInSuccess) {
                           callback);
   };
 
-  auto setup_io_manager_and_decode = [&]() {
+  auto set_up_io_manager_and_decode = [&]() {
     io_manager = std::make_unique<TestIOManager>(runners.GetIOTaskRunner());
     runners.GetUITaskRunner()->PostTask(decode_image);
   };
 
-  runners.GetIOTaskRunner()->PostTask(setup_io_manager_and_decode);
+  runners.GetIOTaskRunner()->PostTask(set_up_io_manager_and_decode);
   latch.Wait();
 }
 
@@ -706,12 +706,12 @@ TEST_F(ImageDecoderFixtureTest, ExifDataIsRespectedOnDecode) {
                           callback);
   };
 
-  auto setup_io_manager_and_decode = [&]() {
+  auto set_up_io_manager_and_decode = [&]() {
     io_manager = std::make_unique<TestIOManager>(runners.GetIOTaskRunner());
     runners.GetUITaskRunner()->PostTask(decode_image);
   };
 
-  runners.GetIOTaskRunner()->PostTask(setup_io_manager_and_decode);
+  runners.GetIOTaskRunner()->PostTask(set_up_io_manager_and_decode);
 
   latch.Wait();
 
@@ -766,13 +766,13 @@ TEST_F(ImageDecoderFixtureTest, CanDecodeWithoutAGPUContext) {
                           callback);
   };
 
-  auto setup_io_manager_and_decode = [&]() {
+  auto set_up_io_manager_and_decode = [&]() {
     io_manager =
         std::make_unique<TestIOManager>(runners.GetIOTaskRunner(), false);
     runners.GetUITaskRunner()->PostTask(decode_image);
   };
 
-  runners.GetIOTaskRunner()->PostTask(setup_io_manager_and_decode);
+  runners.GetIOTaskRunner()->PostTask(set_up_io_manager_and_decode);
 
   latch.Wait();
 }