Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 1ae2c10

Browse files
authored
Move the scenario_app running Impeller+OpenGLES to bringup: triue (#50789)
1. OpenGLES is much flakier than Skia or Vulkan. 2. OpenGLES is not currently being released so it's lower priority to fix. See flutter/flutter#143626.
1 parent f047950 commit 1ae2c10

File tree

3 files changed

+81
-23
lines changed

3 files changed

+81
-23
lines changed

.ci.yaml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,27 @@ targets:
6767
- shell/platform/android/**
6868
- testing/scenario_app/**
6969

70+
# TODO(matanlurey): OpenGLES is very flaky, https://github.com/flutter/flutter/issues/143626.
71+
- name: Linux linux_android_emulator_opengles_tests
72+
bringup: true
73+
enabled_branches:
74+
- main
75+
recipe: engine_v2/engine_v2
76+
properties:
77+
config_name: linux_android_emulator_opengles
78+
dependencies: >-
79+
[
80+
{"dependency": "goldctl", "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"}
81+
]
82+
timeout: 60
83+
runIf:
84+
- .ci.yaml
85+
- ci/builders/linux_android_emulator.json
86+
- DEPS
87+
- lib/ui/**
88+
- shell/platform/android/**
89+
- testing/scenario_app/**
90+
7091
# Task to run Linux linux_android_emulator_tests on AVDs running Android 33
7192
# instead of 34 for investigating https://github.com/flutter/flutter/issues/137947.
7293
- name: Linux linux_android_emulator_tests_api_33

ci/builders/linux_android_emulator.json

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -100,29 +100,6 @@
100100
"--enable-impeller",
101101
"--impeller-backend=vulkan"
102102
]
103-
},
104-
{
105-
"language": "bash",
106-
"name": "Android Scenario App Integration Tests (Impeller/OpenGLES)",
107-
"test_dependencies": [
108-
{
109-
"dependency": "android_virtual_device",
110-
"version": "android_34_google_apis_x64.textpb"
111-
},
112-
{
113-
"dependency": "avd_cipd_version",
114-
"version": "build_id:8759428741582061553"
115-
}
116-
],
117-
"contexts": [
118-
"android_virtual_device"
119-
],
120-
"script": "flutter/testing/scenario_app/run_android_tests.sh",
121-
"parameters": [
122-
"android_debug_x64",
123-
"--enable-impeller",
124-
"--impeller-backend=opengles"
125-
]
126103
}
127104
]
128105
},
Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
{
2+
"builds": [
3+
{
4+
"drone_dimensions": [
5+
"device_type=none",
6+
"os=Linux",
7+
"kvm=1",
8+
"cores=8"
9+
],
10+
"gclient_variables": {
11+
"use_rbe": true
12+
},
13+
"gn": [
14+
"--android",
15+
"--android-cpu=x64",
16+
"--no-lto",
17+
"--rbe",
18+
"--no-goma"
19+
],
20+
"dependencies": [
21+
{
22+
"dependency": "goldctl",
23+
"version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
24+
}
25+
],
26+
"name": "android_debug_x64",
27+
"ninja": {
28+
"config": "android_debug_x64",
29+
"targets": [
30+
"flutter/testing/scenario_app"
31+
]
32+
},
33+
"tests": [
34+
{
35+
"language": "bash",
36+
"name": "Android Scenario App Integration Tests (Impeller/OpenGLES)",
37+
"test_dependencies": [
38+
{
39+
"dependency": "android_virtual_device",
40+
"version": "android_34_google_apis_x64.textpb"
41+
},
42+
{
43+
"dependency": "avd_cipd_version",
44+
"version": "build_id:8759428741582061553"
45+
}
46+
],
47+
"contexts": [
48+
"android_virtual_device"
49+
],
50+
"script": "flutter/testing/scenario_app/run_android_tests.sh",
51+
"parameters": [
52+
"android_debug_x64",
53+
"--enable-impeller",
54+
"--impeller-backend=opengles"
55+
]
56+
}
57+
]
58+
}
59+
]
60+
}

0 commit comments

Comments
 (0)