Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 17217c6

Browse files
null77Commit Bot
authored andcommitted
Vulkan: Fix layers being disabled in tests.
The ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT define shouldn't be being checked in tests. Enable the debug layers by default. Bug: angleproject:4227 Bug: angleproject:4229 Change-Id: I9717cb1c611ebd585a5c03ba2057036e1b086001 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972497 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
1 parent d205ee3 commit 17217c6

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/tests/gl_tests/VulkanExternalImageTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ TEST_P(VulkanExternalImageTest, ShouldImportSemaphoreOpaqueFd)
126126
// Test creating and clearing a simple RGBA8 texture in a opaque fd.
127127
TEST_P(VulkanExternalImageTest, ShouldClearOpaqueFdRGBA8)
128128
{
129-
// http://anglebug.com/4092
130-
ANGLE_SKIP_TEST_IF(isSwiftshader());
129+
// http://anglebug.com/4229
130+
ANGLE_SKIP_TEST_IF(IsVulkan());
131131
ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_memory_object_fd"));
132132

133133
VulkanExternalHelper helper;

src/tests/test_utils/angle_test_configs.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,8 @@ EGLint PlatformParameters::getDeviceType() const
4646

4747
void PlatformParameters::initDefaultParameters()
4848
{
49-
#if defined(ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT)
5049
// Default debug layers to enabled in tests.
5150
eglParameters.debugLayersEnabled = EGL_TRUE;
52-
#else
53-
eglParameters.debugLayersEnabled = EGL_FALSE;
54-
#endif // defined(ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT)
5551
}
5652

5753
bool operator<(const PlatformParameters &a, const PlatformParameters &b)

0 commit comments

Comments
 (0)