Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 0df6740

Browse files
godofredocgodofredoc
authored
Migrate mac host clang tidy to engine v2. (#41824)
This removes the additional gn command from the ci/lint tool and uses a single gn command. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 80880ab commit 0df6740

File tree

2 files changed

+114
-0
lines changed

2 files changed

+114
-0
lines changed

‎.ci.yaml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,13 @@ targets:
376376
properties:
377377
config_name: mac_android_aot_engine
378378

379+
- name: Mac mac_clang_tidy
380+
bringup: true
381+
recipe: engine_v2/engine_v2
382+
timeout: 60
383+
properties:
384+
config_name: mac_clang_tidy
385+
379386
- name: Mac mac_host_engine
380387
recipe: engine_v2/engine_v2
381388
timeout: 60

‎ci/builders/mac_clang_tidy.json‎

Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
{
2+
"builds": [
3+
{
4+
"drone_dimensions": [
5+
"device_type=none",
6+
"os=Mac-12",
7+
"cpu=arm64"
8+
],
9+
"gclient_variables": {
10+
"download_android_deps": false
11+
},
12+
"gn": [
13+
"--runtime-mode",
14+
"debug",
15+
"--prebuilt-dart-sdk",
16+
"--no-lto",
17+
"--force-mac-arm64"
18+
],
19+
"name": "host_debug",
20+
"ninja": {
21+
"config": "host_debug"
22+
}
23+
},
24+
{
25+
"drone_dimensions": [
26+
"device_type=none",
27+
"os=Mac-12",
28+
"cpu=arm64"
29+
],
30+
"gclient_variables": {
31+
"download_android_deps": false
32+
},
33+
"gn": [
34+
"--ios",
35+
"--runtime-mode",
36+
"debug",
37+
"--simulator",
38+
"--no-lto",
39+
"--force-mac-arm64"
40+
],
41+
"name": "ios_debug_sim",
42+
"ninja": {
43+
"config": "ios_debug_sim"
44+
}
45+
}
46+
],
47+
"tests": [
48+
{
49+
"name": "test: lint host_debug",
50+
"recipe": "engine_v2/tester_engine",
51+
"drone_dimensions": [
52+
"device_type=none",
53+
"os=Mac",
54+
"cpu=arm64"
55+
],
56+
"gclient_variables": {
57+
"download_android_deps": false
58+
},
59+
"dependencies": [
60+
"host_debug",
61+
"ios_debug_sim"
62+
],
63+
"tasks": [
64+
{
65+
"name": "test: lint host_debug",
66+
"parameters": [
67+
"--variant",
68+
"host_debug",
69+
"--lint-all",
70+
"--shard-id=1",
71+
"--shard-variants=ios_debug_sim"
72+
],
73+
"script": "flutter/ci/lint.sh"
74+
}
75+
]
76+
},
77+
{
78+
"name": "test: lint ios_debug_sim",
79+
"recipe": "engine_v2/tester_engine",
80+
"drone_dimensions": [
81+
"device_type=none",
82+
"os=Mac",
83+
"cpu=arm64"
84+
],
85+
"gclient_variables": {
86+
"download_android_deps": false
87+
},
88+
"dependencies": [
89+
"host_debug",
90+
"ios_debug_sim"
91+
],
92+
"tasks": [
93+
{
94+
"name": "test: lint ios_debug_sim",
95+
"parameters": [
96+
"--variant",
97+
"ios_debug_sim",
98+
"--lint-all",
99+
"--shard-id=0",
100+
"--shard-variants=host_debug"
101+
],
102+
"script": "flutter/ci/lint.sh"
103+
}
104+
]
105+
}
106+
]
107+
}

0 commit comments

Comments
 (0)