Do not default to downstream affinity on iOS insertText (#13852)

GaryQian · web-flow · commit 0d60e1a324c8 · 2019-11-22T14:02:50.000-08:00
diff --git a/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm b/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm
@@ -621,7 +621,9 @@ - (BOOL)hasText {
 }
 
 - (void)insertText:(NSString*)text {
-  _selectionAffinity = _kTextAffinityDownstream;
+  // The affinity is unknown here. Set to "" so that Flutter interprets it
+  // as ambiguous and uses a fallback affinity.
+  _selectionAffinity = "";
   [self replaceRange:_selectedTextRange withText:text];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -621,7 +621,9 @@ - (BOOL)hasText {`
`621`	`621`	`}`
`622`	`622`
`623`	`623`	`- (void)insertText:(NSString*)text {`
`624`		`- _selectionAffinity = _kTextAffinityDownstream;`
	`624`	`+ // The affinity is unknown here. Set to "" so that Flutter interprets it`
	`625`	`+ // as ambiguous and uses a fallback affinity.`
	`626`	`+ _selectionAffinity = "";`
`625`	`627`	`[self replaceRange:_selectedTextRange withText:text];`
`626`	`628`	`}`
`627`	`629`