Skip to content

Add icons from IntelliJ #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Add icons from IntelliJ #68

merged 1 commit into from
Dec 26, 2018

Conversation

jacob314
Copy link
Contributor

Reusing the same icons where feasible gives us a more consistent look
and feel with the IntelliJ based tooling providing the same features.
For best performance, we should at some point add a build rule to sprite
these icons into a single png.

Reusing the same icons where feasible gives us a more consistent look
and feel with the IntelliJ based tooling providing the same features.
For best performance, we should at some point add a build rule to sprite
these icons into a single png.
@jacob314
Copy link
Contributor Author

Note thee are 3 files that are different although the content is the same. The 3 gif files are animated gifs generated from png sequences used in intellij as the web has animated gif support so there is no sense in reinventing the wheel.

@jacob314
Copy link
Contributor Author

@lambdabaa

Copy link

@lambdabaa lambdabaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacob314 jacob314 merged commit 5abe232 into flutter:master Dec 26, 2018
hrajwade96 pushed a commit to hrajwade96/devtools that referenced this pull request Dec 18, 2024
Add scroll physics option to carousel slider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants