Replace VmService with VmServiceWrapper #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Dec 17, 2018
jacob314
reviewed
Dec 17, 2018
jacob314
reviewed
Dec 17, 2018
jacob314
reviewed
Dec 17, 2018
jacob314
reviewed
Dec 17, 2018
jacob314
reviewed
Dec 17, 2018
| } | ||
|
|
||
| @override | ||
| Future<Success> streamListen(String streamId) { |
There was a problem hiding this comment.
add a comment explaining why we intentionally tweaked this method.
There was a problem hiding this comment.
Added
"We tweaked this method so that we do not try to listen to the same stream. This was causing an issue with the test environment and this change should not affect the run environment."
Sg?
There was a problem hiding this comment.
Here's some advice from the flutter team on how to write good comments. We can be a little more lax as fewer people will be reading our comments but in general, this is great advice on how to comment code.
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#documentation-dartdocs-javadocs-etc
jacob314
reviewed
Dec 17, 2018
jacob314
reviewed
Dec 17, 2018
jacob314
reviewed
Dec 17, 2018
jacob314
reviewed
Dec 17, 2018
jacob314
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.