Add skeleton for offline integration tests and add CLI flags #5027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderDake
approved these changes
Jan 10, 2023
packages/devtools_app/integration_test/test_infra/_run_test.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/integration_test/test_infra/_run_test.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds directories
live_connectionandofflineunderintegration_test/testto differentiate between integration tests that will be run against and live app and integration tests that will be run with offline data. Each directory contains a README.md file.This PR also modifies the test runner script to
--offlineand--enable-experimentsflags should be added based on the test target path. (A follow up PR to add the Perfetto integration test will be underoffline/experimentaland will leverage this functionality.--offlineand--update-goldens(used in a future PR).RELEASE_NOTE_EXCEPTION=[testing changes]