Add sample data dropdown to landing screen for use in integration tests #5024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
requested review from
bkonyi and
CoderDake
and removed request for
a team
CoderDake
reviewed
Jan 10, 2023
| expect(find.byType(AppSizeToolingInstructions), findsOneWidget); | ||
| }); | ||
|
|
||
| testWidgetsWithWindowSize( |
There was a problem hiding this comment.
Could we add a test to make sure this doesn't show in release mode?
There was a problem hiding this comment.
There isn't an easy way that I'm aware of to mock the value of kReleaseMode. The only way to test this would be to add another job to our github actions that runs the test suite in release mode, which may be a bit overkill for a test this small.
CoderDake
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is flagged to ensure this sample data picker never shows up in release mode. This allows for loading sample data into DevTools without the data existing in a local file system.
RELEASE_NOTE_EXCEPTION=testing change