Add Safari fix to release notes #4966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,8 @@ This is draft for future release notes, that are going to land on | |||
| Dart & Flutter DevTools - A Suite of Performance Tools for Dart and Flutter | |||
|
|
|||
| ## General updates | |||
| TODO: Remove this section if there are not any general updates. | |||
|
|
|||
| - Fix an issue in Safari (browsers that do not support RegExp negative lookbehind) that prevented DevTools from loading. | |||
There was a problem hiding this comment.
can you add a link to the PR?
There was a problem hiding this comment.
Done! I copied format from https://github.com/flutter/devtools/blob/master/CHANGELOG.md (PR link at the end).
I also added another PR I saw I'd missed that made some fixes to syntax highlighting.
kenzieschmoll
approved these changes
Dec 21, 2022
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds #4938 to release notes.
(feel free to suggest wording changes.. I wasn't sure what the official line is on Safari and whether to recommend Chrome or add any disclaimer)