Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ide theme color not getting set certain UI elements #8230

Open
kenzieschmoll opened this issue Aug 22, 2024 · 3 comments
Open

Ide theme color not getting set certain UI elements #8230

kenzieschmoll opened this issue Aug 22, 2024 · 3 comments
Assignees
Labels
cost: low Low engineering cost to implement. fix it friday ide-integration P2 important to work on, but not at the top of the work list. polish

Comments

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Aug 22, 2024

The lighter gray is getting passed in by the query parameters from the IDE, but it is not getting applied everywhere:
Screenshot 2024-08-22 at 1 47 06 PM
Screenshot 2024-08-22 at 1 52 07 PM
Screenshot 2024-08-22 at 1 45 20 PM
URL:
Screenshot 2024-08-22 at 1 51 13 PM

@kenzieschmoll kenzieschmoll added polish ide-integration P2 important to work on, but not at the top of the work list. fix it friday cost: low Low engineering cost to implement. labels Aug 22, 2024
@elliette
Copy link
Member

Also seeing this on the Network Panel:

Screenshot 2024-08-22 at 1 47 10 PM

@elliette
Copy link
Member

elliette commented Aug 22, 2024

Performance panel:

Screenshot 2024-08-22 at 1 59 13 PM

Screenshot 2024-08-22 at 1 59 05 PM

Screenshot 2024-08-22 at 2 00 41 PM

@elliette
Copy link
Member

Investigating #8466, I've discovered why this happens:

  • We do not set the colorScheme in the Theme we construct from the IDE background color, so any color properties we access on colorScheme will not be set to work with the IDE theme.
  • Furthermore, DevToolsSharedColorScheme does not take into consideration the IDE theme:
    extension DevToolsSharedColorScheme on ColorScheme {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cost: low Low engineering cost to implement. fix it friday ide-integration P2 important to work on, but not at the top of the work list. polish
Projects
None yet
Development

No branches or pull requests

2 participants