Skip to content

Commit c6e3cd5

Browse files
committed
Delete launched wasmOptIn feature flag
1 parent 2f73978 commit c6e3cd5

File tree

4 files changed

+15
-30
lines changed

4 files changed

+15
-30
lines changed

packages/devtools_app/lib/src/framework/scaffold/settings_dialog.dart

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import 'package:provider/provider.dart';
1111
import '../../shared/analytics/analytics_controller.dart';
1212
import '../../shared/analytics/constants.dart' as gac;
1313
import '../../shared/config_specific/copy_to_clipboard/copy_to_clipboard.dart';
14-
import '../../shared/feature_flags.dart';
1514
import '../../shared/globals.dart';
1615
import '../../shared/log_storage.dart';
1716
import '../../shared/server/server.dart';
@@ -77,23 +76,21 @@ class SettingsDialog extends StatelessWidget {
7776
gaItem: gac.vmDeveloperMode,
7877
),
7978
),
80-
if (FeatureFlags.wasmOptInSetting.isEnabled) ...[
81-
const SizedBox(height: largeSpacing),
82-
...dialogSubHeader(theme, 'Experimental features'),
83-
Flexible(
84-
child: CheckboxSetting(
85-
title: '[Recommended] Enable WebAssembly',
86-
description:
87-
'This will trigger a reload of the page to load DevTools '
88-
'compiled with WebAssembly. This may yield better '
89-
'performance.',
90-
notifier: preferences.wasmEnabled,
91-
onChanged: preferences.toggleWasmEnabled,
92-
gaScreen: gac.settingsDialog,
93-
gaItem: gac.wasm,
94-
),
79+
const SizedBox(height: largeSpacing),
80+
...dialogSubHeader(theme, 'Experimental features'),
81+
Flexible(
82+
child: CheckboxSetting(
83+
title: '[Recommended] Enable WebAssembly',
84+
description:
85+
'This will trigger a reload of the page to load DevTools '
86+
'compiled with WebAssembly. This may yield better '
87+
'performance.',
88+
notifier: preferences.wasmEnabled,
89+
onChanged: preferences.toggleWasmEnabled,
90+
gaScreen: gac.settingsDialog,
91+
gaItem: gac.wasm,
9592
),
96-
],
93+
),
9794
const SizedBox(height: largeSpacing),
9895
...dialogSubHeader(theme, 'Troubleshooting'),
9996
const _VerboseLoggingSetting(),

packages/devtools_app/lib/src/shared/feature_flags.dart

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,6 @@ extension FeatureFlags on Never {
8585
enabled: true,
8686
);
8787

88-
/// Flag to enable the DevTools setting to opt-in to WASM.
89-
///
90-
/// https://github.com/flutter/devtools/issues/7856
91-
static final wasmOptInSetting = BooleanFeatureFlag(
92-
name: 'wasmOptInSetting',
93-
enabled: true,
94-
);
95-
9688
/// Flag to enable refactors in the Flutter Property Editor sidebar.
9789
///
9890
/// https://github.com/flutter/devtools/issues/9214
@@ -121,7 +113,6 @@ extension FeatureFlags on Never {
121113
devToolsExtensions,
122114
dapDebugging,
123115
inspectorV2,
124-
wasmOptInSetting,
125116
propertyEditorRefactors,
126117
};
127118

packages/devtools_app/lib/src/shared/preferences/preferences.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,7 @@ class PreferencesController extends DisposableController
122122
// Get the current values and listen for and write back changes.
123123
await _initDarkMode();
124124
await _initAdvancedDeveloperMode();
125-
if (FeatureFlags.wasmOptInSetting.isEnabled) {
126-
await _initWasmEnabled();
127-
}
125+
await _initWasmEnabled();
128126
await _initVerboseLogging();
129127

130128
await cpuProfiler.init();

packages/devtools_app/test/shared/primitives/feature_flags_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ void main() {
2121
expect(FeatureFlags.devToolsExtensions.isEnabled, isExternalBuild);
2222
expect(FeatureFlags.dapDebugging.isEnabled, false);
2323
expect(FeatureFlags.inspectorV2.isEnabled, true);
24-
expect(FeatureFlags.wasmOptInSetting.isEnabled, true);
2524
expect(FeatureFlags.propertyEditorRefactors.isEnabled, true);
2625
});
2726

0 commit comments

Comments
 (0)