Skip to content

Commit c43d361

Browse files
authored
remove the package:logging dep (#44)
1 parent d192ff1 commit c43d361

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

lib/logging/logging.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import 'dart:async';
66
import 'dart:convert';
77

88
import 'package:intl/intl.dart';
9-
import 'package:logging/logging.dart';
109
import 'package:vm_service_lib/vm_service_lib.dart';
1110

1211
import '../framework/framework.dart';
@@ -143,7 +142,7 @@ class LoggingScreen extends Screen {
143142
final int time = ((newSpace.time + oldSpace.time) * 1000).round();
144143

145144
final String summary = '${isolateRef['name']} • '
146-
'${e.json['reason']} collection $time ms • '
145+
'${e.json['reason']} collection in $time ms • '
147146
'${printMb(usedBytes)} MB used of ${printMb(capacityBytes)} MB';
148147
final Map<String, dynamic> event = <String, dynamic>{
149148
'reason': e.json['reason'],
@@ -221,8 +220,8 @@ class LoggingScreen extends Screen {
221220
});
222221
}
223222

224-
final bool isError =
225-
level != null && level >= Level.SEVERE.value ? true : false;
223+
const int severeIssue = 1000;
224+
final bool isError = level != null && level >= severeIssue ? true : false;
226225

227226
_log(new LogData(
228227
loggerName,

pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ environment:
88

99
dependencies:
1010
intl: ^0.15.0
11-
logging: ^0.11.0
1211
meta: ^1.1.0
1312
path: ^1.6.0
1413
vm_service_lib: ^0.3.9+1

0 commit comments

Comments
 (0)