iOS,macOS: Skip codesigning files in unsigned_binaries.txt #3890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
commented
Sep 5, 2024
| @@ -124,26 +130,30 @@ class FileCodesignVisitor { | |||
| static final RegExp _notarytoolStatusCheckPattern = RegExp(r'[ ]*status: ([a-zA-z ]+)'); | |||
| static final RegExp _notarytoolRequestPattern = RegExp(r'id: ([a-z0-9-]+)'); | |||
|
|
|||
| static const String fixItInstructions = ''' | |||
| static final String fixItInstructions = ''' | |||
There was a problem hiding this comment.
Because we're using the filenames from the enum now rather than hardcoding.
There was a problem hiding this comment.
interesting that dereferencing this is not a const expression, but oh well
cbracken
force-pushed
the
add-unsigned
branch
2 times, most recently
from
39bb7a5 to
61da2b6
Compare
jmagman
approved these changes
Sep 5, 2024
cbracken
force-pushed
the
add-unsigned
branch
from
61da2b6 to
04d4a86
Compare
|
Note: Updated a doc comment and improved a variable name in a followup commit just now. |
This updates the code-signing workflow to account for iOS and macOS binaries in the artifact cache that are _expected_ to not be codesigned. In flutter/engine#54414 we started bundling dSYM (debugging symbols) within Flutter.xcframework, a requirement for App Store verification using Xcode 16. We did the same for macOS in flutter/engine#54696. Unlike the framework dylib, dSYM contents are not directly codesigned (though the xcframework containing them is). This skips code-signing for files found in `unsigned_binaries.txt`, which will be added in a followup patch to the framework artifact archive creation scripts in engine: * `sky/tools/create_ios_framework.py` * `sky/tools/create_macos_framework.py` Issue: flutter/flutter#154571
cbracken
force-pushed
the
add-unsigned
branch
from
04d4a86 to
85cf234
Compare
cbracken
added
the
autosubmit
9 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 5, 2024
There are three categories of binaries produced as part of the framework artifacts: * Those that use APIs that require entitlements and must be code-signed; e.g. gen_snapshot * Those that do not use APIs that require entitlements and must be code-signed; e.g. Flutter.framework dylib. * Those that do not need to be code-signed; e.g. Flutter.dSYM symbols. We are adding the third category in flutter/engine#54977. The Cocoon code signing aspect of this was handled in flutter/cocoon#3890. This ensures these files don't get copied into the build output should they appear in the artifact cache. Issue: #154571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code-signing workflow to account for iOS and macOS binaries in the artifact cache that are expected to not be codesigned.
In flutter/engine#54414 we started bundling dSYM (debugging symbols) within Flutter.xcframework, a requirement for App Store verification using Xcode 16.
We did the same for macOS in flutter/engine#54696.
Unlike the framework dylib, dSYM contents are not directly codesigned (though the xcframework containing them is). This skips code-signing for files found in
unsigned_binaries.txt, which will be added in a followup patch to the framework artifact archive creation scripts in engine:sky/tools/create_ios_framework.pysky/tools/create_macos_framework.pyIssue: flutter/flutter#154571
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.