This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Bump to Android API 34 #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Added you all as reviewers individually because I can't use the reviewers group here for some reason |
reidbaker
approved these changes
Nov 2, 2023
Contributor
|
I also double checked that 34.0.0 was the latest sdk tools published as of today. |
8 tasks
gmackall
added
the
autosubmit
gmackall
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
This reverts commit 6508cc5.
8 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Nov 6, 2023
Reverts #790 Initiated by: gmackall This change reverts the following previous change: Original Description: See the last time this was done #601. Needed to bump the engine to use Android 14. New version was just uploaded https://chrome-infra-packages.appspot.com/p/flutter/android/sdk/all
Member
Author
|
Reverting this because the linux version of the CIPD package we depend on doesn't include the ndk subdirectory, leading to the following error: Will reland when a corrected CIPD package is uploaded (the PR itself is fine, it just can't land until that package is uploaded correctly). TODO is to figure out why the script didn't run correctly (https://github.com/flutter/engine/blob/master_archived/tools/android_sdk/create_cipd_packages.sh) |
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Re-land #790 now that flutter/engine#47609 is approved and passing checks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Nov 8, 2023
~**This should not land until flutter/buildroot#790 (re)lands, and I swap the buildroot url back to the latest commit.**~ ~Reland of PR to update buildroot at flutter/buildroot#792. ~ <- landed, and changed the buildroot commit to the latest in DEPS Upgrades to android api 34 Also: 1. Upgrades to java 17 in DEPS/ci, because the linter now requires it. 2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either. 3. Applies the four trivial new suggestions from the newer linter. 4. Updates the baseline lint to include the new non-trivial lint ([fixed in a different PR](https://github.com/flutter/engine/pull/47817/files)). 5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the [comment below](#47609 (comment))). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Nov 8, 2023
Reverts #47609 Initiated by: zanderso This change reverts the following previous change: Original Description: ~**This should not land until flutter/buildroot#790 (re)lands, and I swap the buildroot url back to the latest commit.**~ ~Reland of PR to update buildroot at flutter/buildroot#792. ~ <- landed, and changed the buildroot commit to the latest in DEPS Upgrades to android api 34 Also: 1. Upgrades to java 17 in DEPS/ci, because the linter now requires it. 2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either. 3. Applies the four trivial new suggestions from the newer linter. 4. Updates the baseline lint to include the new non-trivial lint ([fixed in a different PR](https://github.com/flutter/engine/pull/47817/files)). 5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the [comment below](#47609 (comment))). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the last time this was done #601.
Needed to bump the engine to use Android 14.
New version was just uploaded https://chrome-infra-packages.appspot.com/p/flutter/android/sdk/all
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.