Skip to content

update to package:web #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2024
Merged

update to package:web #29

merged 3 commits into from
Apr 8, 2024
+885 −771

Conversation

jezell
Copy link

@jezell jezell commented Mar 12, 2024

Fixes #28

@jezell jezell mentioned this pull request Mar 12, 2024
Merged
@cloudwebrtc
Copy link
Member

Using web.crypto.subtle.importKey will report an error in web worker mode, and still use js interop mode. But the dart:html dependency is removed, and this modification passed the test

image

cloudwebrtc
cloudwebrtc approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cloudwebrtc cloudwebrtc merged commit 6b2411b into flutter-webrtc:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move from to dart:html to package:web
3 participants
@jezell @cloudwebrtc @timu-jesse-ezell