Skip to content

Commit 8b81d6e

Browse files
committed
Update based on reviews
1 parent da8b248 commit 8b81d6e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/webview_flutter/tizen/src/webview.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include "lwe/PlatformIntegrationData.h"
2020
#include "webview_factory.h"
2121

22-
static const size_t kBufferPoolSize = 5;
22+
static constexpr size_t kBufferPoolSize = 5;
2323

2424
extern "C" size_t LWE_EXPORT createWebViewInstance(
2525
unsigned x, unsigned y, unsigned width, unsigned height,
@@ -65,7 +65,7 @@ class NavigationRequestResult
6565
WebView* webview_;
6666
};
6767

68-
enum ResourceErrorType {
68+
enum class ResourceErrorType {
6969
NoError,
7070
UnknownError,
7171
HostLookupError,
@@ -85,7 +85,7 @@ enum ResourceErrorType {
8585
};
8686

8787
static std::string ErrorCodeToString(int error_code) {
88-
switch (error_code) {
88+
switch (ResourceErrorType(error_code)) {
8989
case ResourceErrorType::AuthenticationError:
9090
return "authentication";
9191
case ResourceErrorType::BadURLError:

packages/webview_flutter/tizen/src/webview_factory.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ WebViewFactory::WebViewFactory(flutter::PluginRegistrar* registrar)
3030
texture_registrar_ = registrar->texture_registrar();
3131

3232
std::string data_path = GetAppDataPath();
33-
std::string storage_path = data_path + "StarFish_localStorage.db";
33+
std::string local_storage_path = data_path + "StarFish_localStorage.db";
3434
std::string cookie_path = data_path + "StarFish_cookies.db";
3535
std::string cache_path = data_path + "Starfish_cache.db";
3636

37-
LWE::LWE::Initialize(storage_path.c_str(), cookie_path.c_str(),
37+
LWE::LWE::Initialize(local_storage_path.c_str(), cookie_path.c_str(),
3838
cache_path.c_str());
3939
}
4040

0 commit comments

Comments
 (0)