Skip to content

Resolve some linter warnings #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

swift-kim
Copy link
Member

@swift-kim swift-kim commented May 24, 2021

Resolve some warnings generated by clang-tidy to meet the Google C++ style convention.

  • Add missing braces.
  • Convert C-style casts to C++-style casts (static_cast, reinterpret_cast). Return types of some functions (e.g. GetImageHandle) were changed as necessary.
  • Format TODOs.

There only remain 4 warnings now. I'm not going to fix them right now.

How to run clang-tidy:

  1. Add this line to the .clang-tidy file.

    WarningsAsErrors: 'google-*'
    
  2. Replace calcTidyPath(firstCommand) with 'clang-tidy-11' in ci/bin/lint.dart.
  3. Run ci/lint.sh.

@swift-kim swift-kim requested a review from a team May 24, 2021 08:38
Copy link

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swift-kim swift-kim mentioned this pull request May 25, 2021
@swift-kim
Copy link
Member Author

I'll resolve conflicts when #86 is merged.

@swift-kim
Copy link
Member Author

swift-kim commented Jun 1, 2021

Rebased and added a commit related to TextInputTypeToEcoreIMFInputPanelLayout.

❌ Failures for clang-tidy on /home/swift/Git/engine/src/flutter/shell/platform/tizen/channels/text_input_channel.cc:
/home/swift/Git/engine/src/flutter/shell/platform/tizen/channels/text_input_channel.cc:63:35: error: non-const reference parameter 'panel_layout', make it const or use a pointer [google-runtime-references,-warnings-as-errors]
    Ecore_IMF_Input_Panel_Layout& panel_layout) {

@swift-kim swift-kim merged commit cd524ba into flutter-tizen:flutter-2.0.1-tizen Jun 1, 2021
@bbrto21
Copy link

bbrto21 commented Jun 1, 2021

Rebased and added a commit related to TextInputTypeToEcoreIMFInputPanelLayout.

❌ Failures for clang-tidy on /home/swift/Git/engine/src/flutter/shell/platform/tizen/channels/text_input_channel.cc:
/home/swift/Git/engine/src/flutter/shell/platform/tizen/channels/text_input_channel.cc:63:35: error: non-const reference parameter 'panel_layout', make it const or use a pointer [google-runtime-references,-warnings-as-errors]
    Ecore_IMF_Input_Panel_Layout& panel_layout) {

Reference : https://stackoverflow.com/questions/26441220/googles-style-guide-about-input-output-parameters-as-pointers/26441753#26441753

swift-kim added a commit that referenced this pull request Jun 7, 2021
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request Sep 27, 2021
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request Nov 14, 2021
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request Dec 9, 2021
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request Dec 17, 2021
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request Feb 7, 2022
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request Feb 11, 2022
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request May 12, 2022
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request Aug 5, 2022
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
swift-kim added a commit that referenced this pull request Sep 1, 2022
* Resolve some linter warnings

* Remove TODOs

* Resolve google-runtime-references warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants