Improve text input #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See flutter-tizen#28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bwikbs
approved these changes
Feb 23, 2021
swift-kim
approved these changes
Feb 23, 2021
swift-kim
pushed a commit
that referenced
this pull request
Mar 10, 2021
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please re-implement it, when the problem is fully identified
and solved. See Support screen rotations for tizen4.0 and tizen6.0 #28 for more details
When using ecore-imf, disappointingly, The behavior of
several factors related to text input in each device profile
is different(such as key-event, calling callbacks for imf).
So I've fine-tuned it, but this may not be the best.
Maybe it's better to separate it by profile in the future.
Signed-off-by: Boram Bae boram21.bae@samsung.com