Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the flutter namespace #121

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Use the flutter namespace #121

merged 5 commits into from
Jun 23, 2021

Conversation

swift-kim
Copy link
Member

@swift-kim swift-kim commented Jun 21, 2021 •
edited
Loading

  • Use the flutter namespace across the Tizen embedder
  • Use unnamed namespaces instead of static for some constants and functions
  • Organize includes & minor clean-ups

@swift-kim swift-kim force-pushed the refactor-channels branch from 7f8cc67 to 492e58d Compare June 21, 2021 23:51
@swift-kim swift-kim requested a review from a team June 22, 2021 00:40
bwikbs
bwikbs approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goood!

HakkyuKim
HakkyuKim approved these changes Jun 22, 2021
View reviewed changes
Copy link

@HakkyuKim HakkyuKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swift-kim swift-kim merged commit bdd0af4 into flutter-tizen:flutter-2.2.1-tizen Jun 23, 2021
swift-kim added a commit that referenced this pull request Sep 27, 2021
@swift-kim
Use the flutter namespace (#121)
06a050d 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
swift-kim added a commit that referenced this pull request Nov 14, 2021
@swift-kim
Use the flutter namespace (#121)
5a1917a 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
swift-kim added a commit that referenced this pull request Dec 9, 2021
@swift-kim
Use the flutter namespace (#121)
85c27d0 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
swift-kim added a commit that referenced this pull request Dec 17, 2021
@swift-kim
Use the flutter namespace (#121)
6bcba06 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
swift-kim added a commit that referenced this pull request Feb 7, 2022
@swift-kim
Use the flutter namespace (#121)
d0d370a 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
swift-kim added a commit that referenced this pull request Feb 11, 2022
@swift-kim
Use the flutter namespace (#121)
db5c1b6 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
swift-kim added a commit that referenced this pull request May 12, 2022
@swift-kim
Use the flutter namespace (#121)
343ebb9 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
swift-kim added a commit that referenced this pull request Aug 5, 2022
@swift-kim
Use the flutter namespace (#121)
97ee76a 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@bdero @dnfield
Use the stencil buffer to avoid overdraw when rendering non-opaque so…
4248b5d 
…lid strokes. (#121)

Fixes flutter/flutter#101330
swift-kim added a commit that referenced this pull request Sep 1, 2022
@swift-kim
Use the flutter namespace (#121)
5ef739a 
* Remove engine dependency of LifecycleChannel

* Minor formatting

* Organize headers

* Use the flutter namespace

* Revert "Remove engine dependency of LifecycleChannel"

This reverts commit a45473d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwikbs bwikbs bwikbs approved these changes

@HakkyuKim HakkyuKim HakkyuKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swift-kim @bwikbs @HakkyuKim