Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormBuildRadio should support Direction Parameter #255

Closed
WilliamCunhaCardoso opened this issue Apr 14, 2020 · 3 comments
Closed

FormBuildRadio should support Direction Parameter #255

WilliamCunhaCardoso opened this issue Apr 14, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@WilliamCunhaCardoso
Copy link
Collaborator

This List should support direction param so we could define axis.horizontal vs vertical

@danvick
Copy link
Collaborator

danvick commented May 1, 2020

Hi @WilliamCunhaCardoso,
This is a nice idea. But how exactly to implement it would be a bit of an issue. For example how many radios to show in a line, the width of the items, how to handle overflows, etc.

More ideas, suggestions on how to handle this, or better yet a PR will be highly appreciated.

@danvick danvick added the good first issue Good for newcomers label May 1, 2020
@robertos95
Copy link

I was about to raise a similar issue as well.
@danvick I think usually when we use the horizontal radio button options, we are already aware that we will only have few and fixed options (e.g. genders - male, female, others). So I think without the overflow handling, this would still be a great feature (maybe can just put some note on the API).

@danvick
Copy link
Collaborator

danvick commented Jul 5, 2020

Kindly use FormBuilderRadioGroup field.

@danvick danvick closed this as completed Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants