Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N and i10n #17

Closed
ghost opened this issue Jan 17, 2019 · 8 comments
Closed

I18N and i10n #17

ghost opened this issue Jan 17, 2019 · 8 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@ghost
Copy link

ghost commented Jan 17, 2019

This is an awesome package for speeding up mundane data pumping apps.

What's your thoughts on i18n ( language translation ) and i10n ( datatime, currency, etc ) formatting

I am using a pure JSON i18n approach which I a bit different from the standard approach so that the JSON files are more reusable.
Then using simple getText calls to get the translations.
If there is datatime or currency then I wrap the getText to also pass in the datetime or currency in, then get the translated text and then replace the datetime and currency with the real value formatted to the correct local.

I don't do any of the codegen of dart code to wrap the translation as I found it just does not properly support i10n use cases. Too many edge cases.

You still get type checking with getText because you can run a simple AST style checker to walk the dart code and check your keys are there in the JSON files for every language.

I am also not using dart to do the translation workflow.
Instead just use golang so it reusable I'm lots of things.
This is all used at design time.

Then just getText at runtime.

Thoughts ??? Useful for form builder ??

@danvick
Copy link
Collaborator

danvick commented Jan 18, 2019

Seems useful.
There are lots of issues and improvements to be done in the current version, I was planning of doing a v2 which will be a complete rewrite - maybe you should get involved. You seem more experienced than me :-).

@ghost
Copy link
Author

ghost commented Jan 19, 2019

Yeah I am happy to get more involved.

Maybe if you write down what and why for V2 somewhere to get the ball rolling.

I have a few ideas myself for other things needed for a form builder than just i18n too.
Printing and pdf
Cross platform ( mobile and desktop )
Grpc for server to flutter communication for rpc.
Events system between server and flutter as well as event bus between flutter components.
Html --> flutter forms. Basically a JSON serialisation of forms layout. Useful for web and flutter apps all using dart

@ghost
Copy link
Author

ghost commented Jan 31, 2019

@danvick Hey I am working on different aspects of this. If you get time to scribble some roadmap notes down it will help.

Currently working on i18n and i10n and it working with validation messages

@danvick
Copy link
Collaborator

danvick commented Apr 3, 2019

Hi @gedw99,
Sorry for taking this long before getting back to you on this.

You'd be glad to know that I have been working on improving the plugin before incorporating your much needed brilliant ideas.
Now check out a branch named version3 which is a complete rewrite of the codebase and I think will close most of the current issues raised.

I'm planning to release this version within the next two weeks, and I'd be glad to have you have a look before then. The documentation for this version is not currently not complete but feel free to poke around and advise as we plan for these suggestions.

Cheers

@ghost
Copy link
Author

ghost commented Apr 5, 2019

Awesome will hit the V3 branch tonight

@danvick
Copy link
Collaborator

danvick commented Apr 5, 2019

That would be great!

I've already published a beta version on pub and I'm getting some awesome feedback and suggestions already. I'm eagerly waiting for yours.

@danvick
Copy link
Collaborator

danvick commented Jul 8, 2020

Hi all,
This issue is being worked on in Version 4 which is still in the works. Kindly test it out and let's have the feedback. Help in translating the FormBuilderValidator errorTexts is needed. I'll include the guide to contributing to the readme soon.

@danvick
Copy link
Collaborator

danvick commented Nov 29, 2020

I'm closing thiis because we now have i18n support in ^4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant