fix: Fix the Url::percentRecodeQuery method

URLs can have several parameters with the same name (e.g. `?foo=bar&foo=baz`),
which are accessible in an array (see `Url::parseQuery()`).

However, the `percentRecodeQuery` method wasn't aware of this
possibility and was executing the `fullPercentDecode()` method directly
on the array instead of each part of the array.

Author: marienfressinaud

lib/SpiderBits/src/Url.php

@@ -276,7 +276,11 @@ private static function percentRecodeQuery($query)
         $parameters = self::parseQuery($query);
         foreach ($parameters as $name => $value) {
             $name = rawurlencode(self::fullPercentDecode($name));
-            if ($value !== null) {
+            if (is_array($value)) {
+                $value = array_map(function ($partial_value) {
+                    return rawurlencode(self::fullPercentDecode($partial_value));
+                }, $value);
+            } elseif ($value !== null) {
                 $value = rawurlencode(self::fullPercentDecode($value));
             }
             $decoded_parameters[$name] = $value;

tests/lib/SpiderBits/UrlTest.php

@@ -118,6 +118,7 @@ public function sanitizeProvider()
             ['https://example.com/?url=http%3A%2F%2Fexample.fr%2F%3Ffoo%3Dbar&spam=egg', 'https://example.com/?url=http%3A%2F%2Fexample.fr%2F%3Ffoo%3Dbar&spam=egg'], // phpcs:ignore Generic.Files.LineLength.TooLong
             ['https://example.com/?foo?=bar', 'https://example.com/?foo%3F=bar'],
             ['https://example.com/?foo%26=bar&spam=egg', 'https://example.com/?foo%26=bar&spam=egg'],
+            ['https://example.com/?foo=bar?&foo=baz?', 'https://example.com/?foo=bar%3F&foo=baz%3F'],
             ["https://domén-with-accent.com?query=with-àccent", 'https://xn--domn-with-accent-dqb.com/?query=with-%C3%A0ccent'], // phpcs:ignore Generic.Files.LineLength.TooLong
             ["https://host.com?query=with-%C3%A0ccent", 'https://host.com/?query=with-%C3%A0ccent'],
             ["https://host.com?utm_source=gazette%252B-%252Babonn%25C3%25A9s", 'https://host.com/?utm_source=gazette%2B-%2Babonn%C3%A9s'], // phpcs:ignore Generic.Files.LineLength.TooLong