Skip to content

Commit 1ad060e

Browse files
committed
Allow FluidK8sClient auto-detect runtime type for dataset fully clean-up
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
1 parent d21aa79 commit 1ad060e

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

fluid/api/fluid_k8s_client.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,11 @@ def delete_dataset(self, name, namespace=None, wait_until_cleaned_up=False, time
284284
**kwargs):
285285
namespace = namespace or self.namespace
286286

287-
kwargs = {
288-
289-
}
287+
runtime_type = None
288+
obj = self.get_dataset(name, namespace)
289+
if len(obj.status.runtimes) > 0:
290+
# For now, Fluid only supports one bounded runtime
291+
runtime_type = utils.infer_runtime_kind(obj.status.runtimes[0].type)
290292

291293
try:
292294
self.custom_api.delete_namespaced_custom_object(
@@ -324,7 +326,7 @@ def delete_dataset(self, name, namespace=None, wait_until_cleaned_up=False, time
324326
logger.debug(f"Dataset \"{namespace}/{name}\" deleted successfully")
325327

326328
if wait_until_cleaned_up:
327-
self.delete_runtime(name, runtime_type=None, namespace=namespace,
329+
self.delete_runtime(name, runtime_type=runtime_type, namespace=namespace,
328330
wait_until_cleaned_up=wait_until_cleaned_up, timeout=timeout, **kwargs)
329331

330332
def delete_runtime(self, name, runtime_type=None, namespace=None, wait_until_cleaned_up=False,

0 commit comments

Comments
 (0)