Chapter 21 - fix tcp_mojifinder.py crashes on empty search result #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes fluentpython#61 Start the TCP server ```shell % ./tcp_mojifinder.py Building index. Serving on ('127.0.0.1', 2323). Hit CTRL-C to stop. ``` Connect to the TCP server and send a search query which return no results and some results, e.g. `missing` and `hat` ```shell % nc localhost 2323 ?> missing ────────────────────────────────────────────────────────────────── 0 found ?> hat U+2CD4 Ⳕ COPTIC CAPITAL LETTER OLD COPTIC HAT U+2CD5 ⳕ COPTIC SMALL LETTER OLD COPTIC HAT U+A271 ꉱ YI SYLLABLE HAT U+D571 핱 HANGUL SYLLABLE HAT U+1F3A9 🎩 TOP HAT U+1F452 👒 WOMANS HAT U+1F920 🤠 FACE WITH COWBOY HAT U+1F973 🥳 FACE WITH PARTY HORN AND PARTY HAT ────────────────────────────────────────────────────────────────── 8 found ?> ``` The TCP server log contains no errors and doesn't crash the TCP connection: ``` % ./tcp_mojifinder.py Building index. Serving on ('127.0.0.1', 2323). Hit CTRL-C to stop. From ('127.0.0.1', 63756): 'missing' To ('127.0.0.1', 63756): 0 results. From ('127.0.0.1', 63756): 'hat' To ('127.0.0.1', 63756): 8 results. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Start the TCP server
% ./tcp_mojifinder.py Building index. Serving on ('127.0.0.1', 2323). Hit CTRL-C to stop.Connect to the TCP server and send a search query which return no results and some results, e.g.
missingandhatThe TCP server log contains no errors and doesn't crash the TCP connection: