Use StartsWith(char value) for modern TFM

fluentassertions · Apr 8, 2023 · 2a95ebd · 2a95ebd
1 parent d4c4eb5
commit 2a95ebd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/Src/FluentAssertions/CallerIdentifier.cs b/Src/FluentAssertions/CallerIdentifier.cs
@@ -243,7 +243,7 @@ private static bool StartsWithNewKeyword(string candidate)
 
     private static bool IsStringLiteral(string candidate)
     {
-        return candidate.StartsWith("\"", StringComparison.Ordinal);
+        return candidate.StartsWith('\"');
     }
 
     private static bool IsNumeric(string candidate)

diff --git a/Src/FluentAssertions/Common/StringExtensions.cs b/Src/FluentAssertions/Common/StringExtensions.cs
@@ -88,7 +88,7 @@ public static string Combine(this string @this, string other, string separator =
             return @this;
         }
 
-        if (other.StartsWith("[", StringComparison.Ordinal))
+        if (other.StartsWith('['))
         {
             separator = string.Empty;
         }

diff --git a/Src/FluentAssertions/SystemExtensions.cs b/Src/FluentAssertions/SystemExtensions.cs
@@ -16,4 +16,8 @@ public static bool Contains(this string str, string value, StringComparison comp
 
     public static bool Contains(this string str, char value, StringComparison comparison) =>
         str.IndexOf(value, comparison) != -1;
+
+    // https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs,1014
+    public static bool StartsWith(this string str, char value) =>
+        str.Length != 0 && str[0] == value;
 }