file_chunk: add stricter checks for broken meta files #4998
+35
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
This PR improves meta file corruption checking.
The meta file contains at least the following field values.
fluentd/lib/fluent/plugin/buffer/file_chunk.rb
Lines 249 to 254 in fa2eb58
It might be possible that the
@size
is 0.@unique_id
,@created_at
, and@modified_at
are set when FileChunk is initialized, so they definitely have some values.I think these fields should be written in meta file.
So, this PR adds the
id
,c
, andm
fields check.This PR reinforces #1874.
Without this changes, it might causes following error when launch fluentd every time with broken meta file:
Docs Changes:
Release Note: