Skip to content

Backport(v1.16): github: set job permissions (#4581) #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

daipom
Copy link
Contributor

@daipom daipom commented May 14, 2025

Which issue(s) this PR fixes:
Backport #4581.

What this PR does / why we need it:

By default, it is enough to give read permission.
For stale actions, it require manipulate issues,
so write permission is given explicitly.

Docs Changes:

N/A

Release Note:

N/A

**Which issue(s) this PR fixes**:

Fixes N/A

It is related token permission topic
https://scorecard.dev/viewer/?uri=github.com/fluent/fluentd

**What this PR does / why we need it**:

By default, it is enough to give read permission.
For stale actions, it require manipulate issues,
so write permission is given explicitly.

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daipom daipom merged commit 6233202 into v1.16 May 14, 2025
14 of 19 checks passed
@daipom daipom deleted the backport-pr4581 branch May 14, 2025 07:19
@daipom daipom added the CI Test/CI issues label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Test/CI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants