-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload new config without restarting process #2716
Conversation
620e7b0
to
7b64af2
Compare
7b64af2
to
e3dee30
Compare
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
434d98d
to
ce616a0
Compare
4ea8f1c
to
752c83f
Compare
to check if config is valid before invoking configure Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
752c83f
to
ae605ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel StaticConfigAnalysis
gives us special powers to report misconfiguration checking phase. 💪
I've added two comments for small concerns.
because replacing Supervisor#read_config with Fluent::Config.build Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
I noticed we need to update HTTP RPC for this feature. fluentd/lib/fluent/supervisor.rb Line 106 in c809788
|
I believe that we should add a new path for reloading config. |
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Good catch! I forgot about it. I added new endpoint
I think this feature can't support windows like |
I will release v1.9.0.rc1 soon. |
Which issue(s) this PR fixes:
Fixes #2624
What this PR does / why we need it:
This change make fluentd be able to reload new config without restarting process with SIGUSR2 signal.
it's very lighter and safer than existing reloading feature. but it has 2 limitations.
Docs Changes:
Add USR2 description.
Release Note:
same as title