Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor_agent does strange output in v0.14 #1226

Closed
kazegusuri opened this issue Sep 11, 2016 · 3 comments · Fixed by #1232
Closed

monitor_agent does strange output in v0.14 #1226

kazegusuri opened this issue Sep 11, 2016 · 3 comments · Fixed by #1232
Assignees
Labels
bug Something isn't working v0.14

Comments

@kazegusuri
Copy link
Contributor

monitor_agent's ouput in v0.14 is weird and different from in v0.12. With folloing configuration:

<source>
  @type monitor_agent
</source>

<match nginx>
  @type copy
  <store>
    @type stdout
  </store>
</match>

<match nginx2>
  @type stdout
</match>

in v0.12.29

$ curl http://localhost:24220/api/plugins
plugin_id:object:3fe8b81d9c10   plugin_category:input   type:monitor_agent  output_plugin:false retry_count:
plugin_id:object:3fe8b857d768   plugin_category:output  type:copy   output_plugin:true  retry_count:
plugin_id:object:3fe8b857c46c   plugin_category:output  type:stdout output_plugin:true  retry_count:
plugin_id:object:3fe8b81f4038   plugin_category:output  type:stdout output_plugin:true  retry_count:

in v0.14.6

$ curl http://localhost:24220/api/plugins
plugin_id:object:3fa09f9fad74   plugin_category:input   type:monitor_agent  output_plugin:false retry_count:
plugin_id:object:3fa09f53ae4c   plugin_category:unknown type:copy   output_plugin:false retry_count:0
plugin_id:object:3fa09f4ed32c   plugin_category:output  type:stdout output_plugin:true  buffer_total_queued_size:0  retry_count:0
plugin_id:object:3fa09f4ed32c   plugin_category:output  type:stdout output_plugin:true  buffer_total_queued_size:0  retry_count:0
plugin_id:object:3fa09fa5e5e0   plugin_category:output  type:stdout output_plugin:true  buffer_total_queued_size:0  retry_count:0

There seems to be 3 issues.

  1. copy plugin is categorized as unknown
  2. stdout plugin inside copy plugin is duplicate
  3. stdout plugin is not buffered output plugin but displays metrics for buffered plugin such as buffered_total_queue_size
@tagomoris
Copy link
Member

tagomoris commented Sep 12, 2016

  • copy plugin is categorized as unknown.

It's the bug of #plugin_category, not to consider about Fluent::Plugin::MultiOutput.

@tagomoris
Copy link
Member

  • stdout plugin inside copy plugin is duplicated

It's the bug that in_monitor_agent plugin fetches output plugin instances from root_agent.outputs, and output_instance.outputs if output plugin is an instance of MultiOutput.
Now root_agent.outputs contains all output plugin instances including children of MultiOutput.

@tagomoris
Copy link
Member

  • stdout plugin is not buffered output plugin but displays metrics for buffered plugin such as buffered_total_queue_size

This bug description is not correct, because out_stdout can work as both of buffered and non-buffered plugin now (v0.14.5 and later).
But we can remove the buffer instance from @buffer when it works as non-buffered output. If we do so, we can update code of in_monitor_agent, and buffer_total_queued_size will disappear.

@tagomoris tagomoris added bug Something isn't working v0.14 labels Sep 12, 2016
@tagomoris tagomoris self-assigned this Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.14
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants