source-only mode: add initial document #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kenhys merged 5 commits into fluent:1.0 from daipom:add-source-only-mode

Jan 15, 2025

Contributor

daipom commented Jan 10, 2025

fluent/fluentd#4661


          source-only mode: add initial document

ab8032d

fluent/fluentd#4661

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>

daipom requested review from kenhys and Watson1978

January 10, 2025 10:10

Watson1978 reviewed

View reviewed changes

deployment/source-only-mode.md Outdated Show resolved Hide resolved

Watson1978 reviewed

View reviewed changes

deployment/source-only-mode.md Outdated Show resolved Hide resolved

Watson1978 reviewed

View reviewed changes

deployment/source-only-mode.md Outdated Show resolved Hide resolved

Watson1978 reviewed

View reviewed changes

deployment/source-only-mode.md Outdated Show resolved Hide resolved

Watson1978 reviewed

View reviewed changes

deployment/system-config.md Outdated Show resolved Hide resolved


          apply feedback

de81205

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Co-authored-by: Shizuo Fujita <fujita@clear-code.com>

cosmo0920 reviewed

View reviewed changes

Contributor

cosmo0920 left a comment

I commented several concerns at the first glance.

deployment/source-only-mode.md Outdated Show resolved Hide resolved

deployment/source-only-mode.md Outdated Show resolved Hide resolved

deployment/source-only-mode.md Outdated Show resolved Hide resolved

deployment/source-only-mode.md Outdated Show resolved Hide resolved

output/buffer.md Outdated Show resolved Hide resolved

daipom and others added 2 commits

January 15, 2025 16:43


          Apply suggestions from code review

1a24665

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>

Co-authored-by: Hiroshi Hatake <hiroshi@chronosphere.io>


          Apply suggestions from code review

07a94bc

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Co-authored-by: Hiroshi Hatake <hiroshi@chronosphere.io>

Contributor Author

daipom commented Jan 15, 2025

@cosmo0920
Thanks for your review! Fixed!

kenhys reviewed

View reviewed changes

deployment/source-only-mode.md Show resolved Hide resolved

kenhys reviewed

View reviewed changes

deployment/system-config.md Show resolved Hide resolved


          apply feedback

6197f3f

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Co-authored-by: Shizuo Fujita <fujita@clear-code.com>
Co-authored-by: Kentaro Hayashi <kenhys@gmail.com>

kenhys approved these changes

View reviewed changes

Contributor

kenhys left a comment

LGTM.

kenhys merged commit 47d7af5 into fluent:1.0

1 check passed

daipom deleted the add-source-only-mode branch

January 15, 2025 09:00

Contributor Author

daipom commented Jan 15, 2025

Thanks for your review!!

daipom mentioned this pull request

Add with-source-only feature fluent/fluentd#4661

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet