Skip to content

Commit dd5f875

Browse files
authored
github: add Ruby 3.4 for CI (#25)
* github: add Ruby 3.4 for CI Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> * Fix unexpected postposition resque and if behavior Since Ruby 3.4, postposition resque and if causes unexpected behavior. To keep compatibility with previous versions, use if condition. See https://bugs.ruby-lang.org/issues/21132 Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com> --------- Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
1 parent c36e327 commit dd5f875

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

.github/workflows/linux-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
ruby: ['3.3', '3.2', '3.1', '3.0', '2.7']
16+
ruby: ['3.4', '3.3', '3.2', '3.1', '3.0', '2.7']
1717
os: [ubuntu-latest]
1818
experimental: [false]
1919
include:

.github/workflows/macos-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
ruby: ['3.3', '3.2', '3.1', '3.0', '2.7']
15+
ruby: ['3.4', '3.3', '3.2', '3.1', '3.0', '2.7']
1616
os: [macos-latest]
1717

1818
name: Ruby ${{ matrix.ruby }} on ${{ matrix.os }}

.github/workflows/windows-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
ruby: ['3.3', '3.2', '3.1', '3.0', '2.7']
15+
ruby: ['3.4', '3.3', '3.2', '3.1', '3.0', '2.7']
1616
os:
1717
- windows-latest
1818
name: Ruby ${{ matrix.ruby }} on ${{ matrix.os }}

lib/fluent/plugin/parser_winevt_xml.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ def MAKELONG(low, high)
2020
end
2121

2222
def event_id(system_elem)
23-
return (system_elem/'EventID').text rescue nil if @preserve_qualifiers
23+
if @preserve_qualifiers
24+
return (system_elem/'EventID').text rescue nil
25+
end
2426

2527
qualifiers = (system_elem/'EventID').attribute("Qualifiers").text rescue nil
2628
if qualifiers

0 commit comments

Comments
 (0)