Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove minitest to correct misjudge of the framework by flexmock #114

Merged
merged 1 commit into from
Aug 17, 2023
Merged

test: remove minitest to correct misjudge of the framework by flexmock #114

merged 1 commit into from
Aug 17, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Aug 17, 2023 •
edited
Loading

Fix broken tests: #109 (comment)

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible

@daipom
test: remove minitest to correct misjudge of the framework by flexmock
30b476d 
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom daipom marked this pull request as ready for review August 17, 2023 11:00
cosmo0920
cosmo0920 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! This is really what we wanted to solve the CI errors. 👍

@cosmo0920 cosmo0920 merged commit e11df60 into fluent:main Aug 17, 2023
@daipom daipom deleted the remove-minitest branch August 17, 2023 11:17
@daipom
Copy link
Contributor Author

daipom commented Aug 17, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daipom @cosmo0920