Skip to content

rpm: revert suppressing systemd_post macro #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Dec 9, 2024

We don't need to suppress this macro because this macro handles preset, not restart.

I have confirmed that this macro of the package for RHEL 9 is expanded as follows.

if [ $1 -eq 1 ] && [ -x "/usr/lib/systemd/systemd-update-helper" ]; then
    # Initial installation
    /usr/lib/systemd/systemd-update-helper install-system-units fluentd.service || :
fi

@daipom daipom force-pushed the try-recovering-systemd_post-macro branch from b663c46 to 734a377 Compare December 9, 2024 10:23
@daipom daipom changed the title rpm: try recovering systemd_post macro rpm: revert suppressing systemd_post macro Dec 9, 2024
@daipom daipom marked this pull request as ready for review December 9, 2024 10:26
@daipom daipom force-pushed the feature-nodowntime branch 2 times, most recently from 55c021b to 4fed1fe Compare December 10, 2024 01:26
We don't need to suppress this macro because this macro handles
preset, not restart.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom daipom force-pushed the try-recovering-systemd_post-macro branch from 734a377 to 502e8e0 Compare December 10, 2024 01:28
@daipom daipom requested a review from Watson1978 December 10, 2024 02:03
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@daipom daipom merged commit c2821b0 into fluent:feature-nodowntime Dec 10, 2024
161 checks passed
@daipom daipom deleted the try-recovering-systemd_post-macro branch December 10, 2024 02:05
@daipom
Copy link
Contributor Author

daipom commented Dec 10, 2024

Thanks!

kenhys pushed a commit that referenced this pull request Dec 11, 2024
We don't need to suppress this macro because this macro handles preset,
not restart.

I have confirmed that this macro of the package for RHEL 9 is expanded
as follows.

```bash
if [ $1 -eq 1 ] && [ -x "/usr/lib/systemd/systemd-update-helper" ]; then
    # Initial installation
    /usr/lib/systemd/systemd-update-helper install-system-units fluentd.service || :
fi
```

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@kenhys kenhys added this to the 5.2.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants